Skip to content

Commit 5ca09db

Browse files
authored
Merge pull request #239 from asherf/pytest
use pytest style assertions.
2 parents 46b4d25 + b743d42 commit 5ca09db

File tree

2 files changed

+13
-12
lines changed

2 files changed

+13
-12
lines changed

django_prometheus/db/backends/postgis/base.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ class DatabaseWrapper(DatabaseWrapperMixin, base.DatabaseWrapper):
77
def get_connection_params(self):
88
conn_params = super().get_connection_params()
99
conn_params["cursor_factory"] = ExportingCursorWrapper(
10-
psycopg2.extensions.cursor, "postgis", self.vendor,
10+
psycopg2.extensions.cursor, "postgis", self.vendor
1111
)
1212
return conn_params
1313

django_prometheus/testutils.py

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -128,10 +128,11 @@ def assertMetricDiff(
128128
metric_name, frozen_registry, **labels
129129
)
130130
current_value = self.getMetric(metric_name, registry=registry, **labels)
131-
self.assertFalse(
132-
current_value is None,
133-
METRIC_DIFF_ERR_NONE_EXPLANATION
134-
% (metric_name, self.formatLabels(labels), saved_value, current_value),
131+
assert current_value is not None, METRIC_DIFF_ERR_NONE_EXPLANATION % (
132+
metric_name,
133+
self.formatLabels(labels),
134+
saved_value,
135+
current_value,
135136
)
136137
diff = current_value - (saved_value or 0.0)
137138
self.assertEqual(
@@ -160,13 +161,13 @@ def assertMetricCompare(
160161
metric_name, frozen_registry, **labels
161162
)
162163
current_value = self.getMetric(metric_name, registry=registry, **labels)
163-
self.assertFalse(
164-
current_value is None,
165-
METRIC_DIFF_ERR_NONE_EXPLANATION
166-
% (metric_name, self.formatLabels(labels), saved_value, current_value),
164+
assert current_value is not None, METRIC_DIFF_ERR_NONE_EXPLANATION % (
165+
metric_name,
166+
self.formatLabels(labels),
167+
saved_value,
168+
current_value,
167169
)
168-
self.assertTrue(
169-
predicate(saved_value, current_value),
170+
assert predicate(saved_value, current_value) is True, (
170171
METRIC_COMPARE_ERR_EXPLANATION
171-
% (metric_name, self.formatLabels(labels), saved_value, current_value),
172+
% (metric_name, self.formatLabels(labels), saved_value, current_value)
172173
)

0 commit comments

Comments
 (0)