Skip to content

Commit e5ad659

Browse files
authored
Merge pull request #189 from asherf/test1
rename attribute
2 parents 5244c2a + 49c8d83 commit e5ad659

File tree

1 file changed

+41
-33
lines changed

1 file changed

+41
-33
lines changed

django_prometheus/tests/test_testutils.py

Lines changed: 41 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -38,12 +38,12 @@ def setUp(self):
3838
self.some_labelled_gauge.labels("pink", "royal").set(2)
3939
self.some_labelled_gauge.labels("carmin", "indigo").set(3)
4040
self.some_labelled_gauge.labels("carmin", "royal").set(4)
41-
self.t = SomeTestCase()
41+
self.test_case = SomeTestCase()
4242

4343
def testGetMetrics(self):
4444
"""Tests getMetric."""
45-
assert 42 == self.t.getMetric("some_gauge", registry=self.registry)
46-
assert 1 == self.t.getMetric(
45+
assert 42 == self.test_case.getMetric("some_gauge", registry=self.registry)
46+
assert 1 == self.test_case.getMetric(
4747
"some_labelled_gauge",
4848
registry=self.registry,
4949
labelred="pink",
@@ -52,13 +52,15 @@ def testGetMetrics(self):
5252

5353
def testGetMetricVector(self):
5454
"""Tests getMetricVector."""
55-
vector = self.t.getMetricVector(
55+
vector = self.test_case.getMetricVector(
5656
"some_nonexistent_gauge", registry=self.registry
5757
)
5858
assert [] == vector
59-
vector = self.t.getMetricVector("some_gauge", registry=self.registry)
59+
vector = self.test_case.getMetricVector("some_gauge", registry=self.registry)
6060
assert [({}, 42)] == vector
61-
vector = self.t.getMetricVector("some_labelled_gauge", registry=self.registry)
61+
vector = self.test_case.getMetricVector(
62+
"some_labelled_gauge", registry=self.registry
63+
)
6264
assert sorted(
6365
[
6466
({"labelred": u"pink", "labelblue": u"indigo"}, 1),
@@ -72,76 +74,82 @@ def testGetMetricVector(self):
7274
def testAssertMetricEquals(self):
7375
"""Tests assertMetricEquals."""
7476
# First we test that a scalar metric can be tested.
75-
self.t.assertMetricEquals(42, "some_gauge", registry=self.registry)
76-
assert self.t.passes is True
77-
self.t.assertMetricEquals(43, "some_gauge", registry=self.registry)
78-
assert self.t.passes is False
79-
self.t.passes = True
77+
self.test_case.assertMetricEquals(42, "some_gauge", registry=self.registry)
78+
assert self.test_case.passes is True
79+
self.test_case.assertMetricEquals(43, "some_gauge", registry=self.registry)
80+
assert self.test_case.passes is False
81+
self.test_case.passes = True
8082

8183
# Here we test that assertMetricEquals fails on nonexistent gauges.
82-
self.t.assertMetricEquals(42, "some_nonexistent_gauge", registry=self.registry)
83-
assert not self.t.passes
84-
self.t.passes = True
84+
self.test_case.assertMetricEquals(
85+
42, "some_nonexistent_gauge", registry=self.registry
86+
)
87+
assert not self.test_case.passes
88+
self.test_case.passes = True
8589

8690
# Here we test that labelled metrics can be tested.
87-
self.t.assertMetricEquals(
91+
self.test_case.assertMetricEquals(
8892
1,
8993
"some_labelled_gauge",
9094
registry=self.registry,
9195
labelred="pink",
9296
labelblue="indigo",
9397
)
94-
assert self.t.passes is True
95-
self.t.assertMetricEquals(
98+
assert self.test_case.passes is True
99+
self.test_case.assertMetricEquals(
96100
1,
97101
"some_labelled_gauge",
98102
registry=self.registry,
99103
labelred="tomato",
100104
labelblue="sky",
101105
)
102-
assert self.t.passes is False
103-
self.t.passes = True
106+
assert self.test_case.passes is False
107+
self.test_case.passes = True
104108

105109
def testRegistrySaving(self):
106110
"""Tests saveRegistry and frozen registries operations."""
107-
frozen_registry = self.t.saveRegistry(registry=self.registry)
111+
frozen_registry = self.test_case.saveRegistry(registry=self.registry)
108112
# Test that we can manipulate a frozen scalar metric.
109-
assert 42 == self.t.getMetricFromFrozenRegistry("some_gauge", frozen_registry)
113+
assert 42 == self.test_case.getMetricFromFrozenRegistry(
114+
"some_gauge", frozen_registry
115+
)
110116
self.some_gauge.set(99)
111-
assert 42 == self.t.getMetricFromFrozenRegistry("some_gauge", frozen_registry)
112-
self.t.assertMetricDiff(
117+
assert 42 == self.test_case.getMetricFromFrozenRegistry(
118+
"some_gauge", frozen_registry
119+
)
120+
self.test_case.assertMetricDiff(
113121
frozen_registry, 99 - 42, "some_gauge", registry=self.registry
114122
)
115-
assert self.t.passes is True
116-
self.t.assertMetricDiff(
123+
assert self.test_case.passes is True
124+
self.test_case.assertMetricDiff(
117125
frozen_registry, 1, "some_gauge", registry=self.registry
118126
)
119-
assert self.t.passes is False
120-
self.t.passes = True
127+
assert self.test_case.passes is False
128+
self.test_case.passes = True
121129

122130
# Now test the same thing with a labelled metric.
123-
assert 1 == self.t.getMetricFromFrozenRegistry(
131+
assert 1 == self.test_case.getMetricFromFrozenRegistry(
124132
"some_labelled_gauge", frozen_registry, labelred="pink", labelblue="indigo"
125133
)
126134
self.some_labelled_gauge.labels("pink", "indigo").set(5)
127-
assert 1 == self.t.getMetricFromFrozenRegistry(
135+
assert 1 == self.test_case.getMetricFromFrozenRegistry(
128136
"some_labelled_gauge", frozen_registry, labelred="pink", labelblue="indigo"
129137
)
130-
self.t.assertMetricDiff(
138+
self.test_case.assertMetricDiff(
131139
frozen_registry,
132140
5 - 1,
133141
"some_labelled_gauge",
134142
registry=self.registry,
135143
labelred="pink",
136144
labelblue="indigo",
137145
)
138-
assert self.t.passes is True
139-
self.t.assertMetricDiff(
146+
assert self.test_case.passes is True
147+
self.test_case.assertMetricDiff(
140148
frozen_registry,
141149
1,
142150
"some_labelled_gauge",
143151
registry=self.registry,
144152
labelred="pink",
145153
labelblue="indigo",
146154
)
147-
assert self.t.passes is False
155+
assert self.test_case.passes is False

0 commit comments

Comments
 (0)