Skip to content

Commit 17ad67c

Browse files
authored
Merge pull request #1140 from ddabble/fix/admin-tests-on-djmain
Fix failing admin tests when testing against Django's main branch
2 parents 6a849ce + e8cc2b2 commit 17ad67c

File tree

1 file changed

+25
-5
lines changed

1 file changed

+25
-5
lines changed

simple_history/tests/tests/test_admin.py

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -455,6 +455,7 @@ def test_history_form_view_without_getting_history(self):
455455
admin.history_form_view(request, poll.id, history.pk)
456456

457457
context = {
458+
**admin_site.each_context(request),
458459
# Verify this is set for original object
459460
"original": poll,
460461
"change_history": False,
@@ -484,7 +485,10 @@ def test_history_form_view_without_getting_history(self):
484485
"save_on_top": admin.save_on_top,
485486
"root_path": getattr(admin_site, "root_path", None),
486487
}
487-
context.update(admin_site.each_context(request))
488+
# This key didn't exist prior to Django 4.2
489+
if "log_entries" in context:
490+
context["log_entries"] = ANY
491+
488492
mock_render.assert_called_once_with(
489493
request, admin.object_history_form_template, context
490494
)
@@ -509,6 +513,7 @@ def test_history_form_view_getting_history(self):
509513
admin.history_form_view(request, poll.id, history.pk)
510514

511515
context = {
516+
**admin_site.each_context(request),
512517
# Verify this is set for history object not poll object
513518
"original": history.instance,
514519
"change_history": True,
@@ -538,7 +543,10 @@ def test_history_form_view_getting_history(self):
538543
"save_on_top": admin.save_on_top,
539544
"root_path": getattr(admin_site, "root_path", None),
540545
}
541-
context.update(admin_site.each_context(request))
546+
# This key didn't exist prior to Django 4.2
547+
if "log_entries" in context:
548+
context["log_entries"] = ANY
549+
542550
mock_render.assert_called_once_with(
543551
request, admin.object_history_form_template, context
544552
)
@@ -563,6 +571,7 @@ def test_history_form_view_getting_history_with_setting_off(self):
563571
admin.history_form_view(request, poll.id, history.pk)
564572

565573
context = {
574+
**admin_site.each_context(request),
566575
# Verify this is set for history object not poll object
567576
"original": poll,
568577
"change_history": False,
@@ -592,7 +601,10 @@ def test_history_form_view_getting_history_with_setting_off(self):
592601
"save_on_top": admin.save_on_top,
593602
"root_path": getattr(admin_site, "root_path", None),
594603
}
595-
context.update(admin_site.each_context(request))
604+
# This key didn't exist prior to Django 4.2
605+
if "log_entries" in context:
606+
context["log_entries"] = ANY
607+
596608
mock_render.assert_called_once_with(
597609
request, admin.object_history_form_template, context
598610
)
@@ -617,6 +629,7 @@ def test_history_form_view_getting_history_abstract_external(self):
617629
admin.history_form_view(request, obj.id, history.pk)
618630

619631
context = {
632+
**admin_site.each_context(request),
620633
# Verify this is set for history object
621634
"original": history.instance,
622635
"change_history": True,
@@ -648,7 +661,10 @@ def test_history_form_view_getting_history_abstract_external(self):
648661
"save_on_top": admin.save_on_top,
649662
"root_path": getattr(admin_site, "root_path", None),
650663
}
651-
context.update(admin_site.each_context(request))
664+
# This key didn't exist prior to Django 4.2
665+
if "log_entries" in context:
666+
context["log_entries"] = ANY
667+
652668
mock_render.assert_called_once_with(
653669
request, admin.object_history_form_template, context
654670
)
@@ -676,6 +692,7 @@ def test_history_form_view_accepts_additional_context(self):
676692
)
677693

678694
context = {
695+
**admin_site.each_context(request),
679696
# Verify this is set for original object
680697
"anything_else": "will be merged into context",
681698
"original": poll,
@@ -706,7 +723,10 @@ def test_history_form_view_accepts_additional_context(self):
706723
"save_on_top": admin.save_on_top,
707724
"root_path": getattr(admin_site, "root_path", None),
708725
}
709-
context.update(admin_site.each_context(request))
726+
# This key didn't exist prior to Django 4.2
727+
if "log_entries" in context:
728+
context["log_entries"] = ANY
729+
710730
mock_render.assert_called_once_with(
711731
request, admin.object_history_form_template, context
712732
)

0 commit comments

Comments
 (0)