Fixed bulk_create_with_history support for HistoryRecords with relation_name attribute (#593)

Author: xahgmah

CHANGES.rst

@@ -3,6 +3,7 @@ Changes
 
 Unreleased
 ----------
+- Fixed bulk_create_with_history support for HistoryRecords with `relation_name` attribute (gh-591)
 - Added support for bulk_create_with_history for databeses different from PostgreSQL (gh-577)
 - Fixed DoesNotExist error when trying to get instance if object is deleted (gh-571)
 - Fix `model_to_dict` to detect changes in a parent model when using

simple_history/manager.py

@@ -101,8 +101,9 @@ def _as_of_set(self, date):
     def bulk_history_create(self, objs, batch_size=None):
         """Bulk create the history for the objects specified by objs"""
 
-        historical_instances = [
-            self.model(
+        historical_instances = []
+        for instance in objs:
+            row = self.model(
                 history_date=getattr(instance, "_history_date", now()),
                 history_user=getattr(instance, "_history_user", None),
                 history_change_reason=getattr(instance, "changeReason", ""),
@@ -113,8 +114,9 @@ def bulk_history_create(self, objs, batch_size=None):
                     if field.name not in self.model._history_excluded_fields
                 }
             )
-            for instance in objs
-        ]
+            if hasattr(self.model, "history_relation"):
+                row.history_relation_id = instance.pk
+            historical_instances.append(row)
 
         return self.model.objects.bulk_create(
             historical_instances, batch_size=batch_size

simple_history/tests/tests/test_utils.py

@@ -4,7 +4,13 @@
 from mock import Mock, patch
 
 from simple_history.exceptions import NotHistoricalModelError
-from simple_history.tests.models import Document, Place, Poll, PollWithExcludeFields
+from simple_history.tests.models import (
+    Document,
+    Place,
+    Poll,
+    PollWithExcludeFields,
+    Street,
+)
 from simple_history.utils import bulk_create_with_history
 
 
@@ -63,6 +69,17 @@ def test_bulk_create_works_with_excluded_fields(self):
         self.assertEqual(PollWithExcludeFields.objects.count(), 5)
         self.assertEqual(PollWithExcludeFields.history.count(), 5)
 
+    def test_bulk_create_history_with_relation_name(self):
+        self.data = [
+            Street(name="Street 1"),
+            Street(name="Street 2"),
+            Street(name="Street 3"),
+            Street(name="Street 4"),
+        ]
+        bulk_create_with_history(self.data, Street)
+        self.assertEqual(Street.objects.count(), 4)
+        self.assertEqual(Street.log.count(), 4)
+
 
 class BulkCreateWithHistoryTransactionTestCase(TransactionTestCase):
     def setUp(self):