Skip to content

Commit 31e03f4

Browse files
committed
Switch order of checking for model_name vs module_name to stop
deprecation warning
1 parent 0001c47 commit 31e03f4

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

simple_history/admin.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,9 @@ def get_urls(self):
3737
admin_site = self.admin_site
3838
opts = self.model._meta
3939
try:
40-
info = opts.app_label, opts.module_name
41-
except AttributeError:
4240
info = opts.app_label, opts.model_name
41+
except AttributeError:
42+
info = opts.app_label, opts.module_name
4343
history_urls = patterns(
4444
"",
4545
url("^([^/]+)/history/([^/]+)/$",
@@ -128,9 +128,9 @@ def history_form_view(self, request, object_id, version_id):
128128
media = self.media + admin_form.media
129129

130130
try:
131-
model_name = original_opts.module_name
132-
except AttributeError:
133131
model_name = original_opts.model_name
132+
except AttributeError:
133+
model_name = original_opts.module_name
134134
url_triplet = self.admin_site.name, original_opts.app_label, model_name
135135
content_type_id = ContentType.objects.get_for_model(self.model).id
136136
context = {

simple_history/models.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ def revert_url(self):
165165
"""URL for this change in the default admin site."""
166166
opts = model._meta
167167
try:
168-
app_label, model_name = opts.app_label, opts.module_name
169-
except AttributeError:
170168
app_label, model_name = opts.app_label, opts.model_name
169+
except AttributeError:
170+
app_label, model_name = opts.app_label, opts.module_name
171171
return ('%s:%s_%s_simple_history' %
172172
(admin.site.name, app_label, model_name),
173173
[getattr(self, opts.pk.attname), self.history_id])

0 commit comments

Comments
 (0)