Skip to content

Commit 3726327

Browse files
seawolf42Ross Mechanic
authored andcommitted
Fix/better user model determination (#435)
* convert user model determination to proper function call * remove unnecessary checks
1 parent b1826d5 commit 3726327

File tree

2 files changed

+7
-10
lines changed

2 files changed

+7
-10
lines changed

simple_history/models.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
from django.apps import apps
99
from django.conf import settings
1010
from django.contrib import admin
11+
from django.contrib.auth import get_user_model
1112
from django.db import models, router
1213
from django.db.models import Q
1314
from django.db.models.fields.proxy import OrderWrt
@@ -25,6 +26,7 @@
2526
post_create_historical_record,
2627
)
2728

29+
User = get_user_model()
2830
registered_models = {}
2931

3032

@@ -216,9 +218,7 @@ def copy_fields(self, model):
216218
def get_extra_fields(self, model, fields):
217219
"""Return dict of extra fields added to the historical record model"""
218220

219-
user_model = self.user_model or getattr(
220-
settings, 'AUTH_USER_MODEL', 'auth.User'
221-
)
221+
user_model = self.user_model or User
222222

223223
def revert_url(self):
224224
"""URL for this change in the default admin site."""

simple_history/tests/tests/test_manager.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,16 @@
11
from datetime import datetime, timedelta
22
from operator import attrgetter
33

4+
from django.contrib.auth import get_user_model
45
from django.db import IntegrityError
56
from django.test import TestCase, skipUnlessDBFeature
67

7-
try:
8-
from django.contrib.auth import get_user_model
9-
except ImportError:
10-
from django.contrib.auth.models import User
11-
else:
12-
User = get_user_model()
13-
148
from ..models import Document, Poll
159

1610

11+
User = get_user_model()
12+
13+
1714
class AsOfTest(TestCase):
1815
model = Document
1916

0 commit comments

Comments
 (0)