small tweaks to test names for history change reason (#406)

Author: kseever

AUTHORS.rst

@@ -60,6 +60,7 @@ Authors
 - Nathan Villagaray-Carski
 - Mike Spainhower
 - Alexander Anikeev
+- Kyle Seever
 
 Background
 ==========

CONTRIBUTING.rst

@@ -60,6 +60,6 @@ To run tox and generate an HTML code coverage report (available in the
 
     make test
 
-To quickly run the tests against a single version of Python and Django::
+To quickly run the tests against a single version of Python and Django (note: you must ``pip install django`` beforehand)::
 
     python setup.py test

simple_history/tests/models.py

@@ -439,7 +439,7 @@ class UUIDDefaultModel(models.Model):
 setattr(settings, 'SIMPLE_HISTORY_HISTORY_CHANGE_REASON_USE_TEXT_FIELD', True)
 
 
-class TextFieldChangeReasonModel1(models.Model):
+class DefaultTextFieldChangeReasonModel(models.Model):
     greeting = models.CharField(max_length=100)
     history = HistoricalRecords()
 
@@ -448,7 +448,7 @@ class TextFieldChangeReasonModel1(models.Model):
 delattr(settings, 'SIMPLE_HISTORY_HISTORY_CHANGE_REASON_USE_TEXT_FIELD')
 
 
-class TextFieldChangeReasonModel2(models.Model):
+class UserTextFieldChangeReasonModel(models.Model):
     greeting = models.CharField(max_length=100)
     history = HistoricalRecords(
         history_change_reason_field=models.TextField(null=True)

simple_history/tests/tests/test_models.py

@@ -54,8 +54,8 @@
     UUIDModel,
     UUIDDefaultModel,
     WaterLevel,
-    TextFieldChangeReasonModel1,
-    TextFieldChangeReasonModel2,
+    DefaultTextFieldChangeReasonModel,
+    UserTextFieldChangeReasonModel,
     CharFieldChangeReasonModel,
 )
 
@@ -408,33 +408,39 @@ def test_charfield_history_change_reason(self):
         self.assertTrue(isinstance(field, models.CharField))
         self.assertTrue(field.max_length, 100)
 
-    def test_textfield_history_change_reason1(self):
+    def test_default_textfield_history_change_reason(self):
         # TextField usage is determined by settings
-        entry = TextFieldChangeReasonModel1.objects.create(
+        entry = DefaultTextFieldChangeReasonModel.objects.create(
             greeting="what's up?"
         )
         entry.greeting = "what is happening?"
         entry.save()
-        update_change_reason(entry, 'Change greeting.')
+
+        reason = 'Change greeting'
+        update_change_reason(entry, reason)
 
         history = entry.history.all()[0]
         field = history._meta.get_field('history_change_reason')
 
         self.assertTrue(isinstance(field, models.TextField))
+        self.assertEquals(history.history_change_reason, reason)
 
-    def test_textfield_history_change_reason2(self):
+    def test_user_textfield_history_change_reason(self):
         # TextField instance is passed in init
-        entry = TextFieldChangeReasonModel2.objects.create(
+        entry = UserTextFieldChangeReasonModel.objects.create(
             greeting="what's up?"
         )
         entry.greeting = "what is happening?"
         entry.save()
-        update_change_reason(entry, 'Change greeting.')
+
+        reason = 'Change greeting'
+        update_change_reason(entry, reason)
 
         history = entry.history.all()[0]
         field = history._meta.get_field('history_change_reason')
 
         self.assertTrue(isinstance(field, models.TextField))
+        self.assertEqual(history.history_change_reason, reason)
 
     def test_get_prev_record(self):
         poll = Poll(question="what's up?", pub_date=today)