Skip to content

Commit 67c7c43

Browse files
authored
Remove changeReason and update CHANGES to prepare for 3.0.0 (#819)
* Remove changeReason and update CHANGES * call out breaking changes
1 parent c888fcf commit 67c7c43

File tree

2 files changed

+16
-12
lines changed

2 files changed

+16
-12
lines changed

CHANGES.rst

Lines changed: 16 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,16 +3,29 @@ Changes
33

44
Unreleased
55
----------
6+
7+
3.0.0 (2021-04-16)
8+
----------
9+
10+
Breaking changes:
11+
12+
- Removed support for Django 3.0
13+
- Removed `changeReason` in favor of `_change_reason` (see 2.10.0)
14+
15+
Full list of changes:
16+
617
- Removed support for Django versions prior to 2.2 (gh-652)
718
- Migrate from TravisCI to Github Actions (gh-739)
819
- Add Python 3.9 support (gh-745)
920
- Support ``ignore_conflicts`` in ``bulk_create_with_history`` (gh-733)
1021
- Use ``asgiref`` when available instead of thread locals (gh-747)
1122
- Sort imports with isort (gh-751)
1223
- Queryset ``history.as_of`` speed improvements by calculating in the DB (gh-758)
13-
- Increase `black` and `isort` python version to 3.6
14-
- Remove Django 3.0 support
15-
- Add Django 3.2 support
24+
- Increase `black` and `isort` python version to 3.6 (gh-817)
25+
- Remove Django 3.0 support (gh-817)
26+
- Add Django 3.2 support (gh-817)
27+
- Improve French translations (gh-811)
28+
- Remove support for changeReason (gh-819)
1629

1730
2.12.0 (2020-10-14)
1831
-------------------

simple_history/utils.py

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -164,13 +164,4 @@ def get_change_reason_from_object(obj):
164164
if hasattr(obj, "_change_reason"):
165165
return getattr(obj, "_change_reason")
166166

167-
if hasattr(obj, "changeReason"):
168-
warning_msg = (
169-
"Using the attr changeReason to populate history_change_reason is"
170-
" deprecated in 2.10.0 and will be removed in 3.0.0. Use "
171-
"_change_reason instead. "
172-
)
173-
warnings.warn(warning_msg, DeprecationWarning)
174-
return getattr(obj, "changeReason")
175-
176167
return None

0 commit comments

Comments
 (0)