Skip to content

Commit a3da24c

Browse files
committed
Added dictionary comprehensions
1 parent 81ccf5f commit a3da24c

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

simple_history/management/commands/_populate_utils.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,9 @@ def bulk_history_create(model, history_model):
2121
history_model(
2222
history_date=getattr(instance, '_history_date', now()),
2323
history_user=getattr(instance, '_history_user', None),
24-
**dict((field.attname, getattr(instance, field.attname))
25-
for field in instance._meta.fields)
24+
**{
25+
field.attname: getattr(instance, field.attname)
26+
for field in instance._meta.fields
27+
}
2628
) for instance in model.objects.all()]
2729
history_model.objects.bulk_create(historical_instances)

simple_history/models.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -179,8 +179,10 @@ def revert_url(self):
179179
[getattr(self, opts.pk.attname), self.history_id])
180180

181181
def get_instance(self):
182-
return model(**dict([(field.attname, getattr(self, field.attname))
183-
for field in fields.values()]))
182+
return model(**{
183+
field.attname: getattr(self, field.attname)
184+
for field in fields.values()
185+
})
184186

185187
return {
186188
'history_id': models.AutoField(primary_key=True),

0 commit comments

Comments
 (0)