Skip to content

Commit aa5874b

Browse files
SkeenRoss Mechanic
authored andcommitted
Catch render() call, to allow overriding. (#530)
* Added overridable render method in admin.py * Added missing self argument. * Make indirect_render used in both cases. * Rename indirect_render to render_history_view * PEP8 * Update render_history_view signature to unfold args. Co-Authored-By: Ross Mechanic <[email protected]> * Fix argument forwarding
1 parent 85758ec commit aa5874b

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

simple_history/admin.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,9 @@ def history_view(self, request, object_id, extra_context=None):
9393
context.update(self.admin_site.each_context(request))
9494
context.update(extra_context or {})
9595
extra_kwargs = {}
96-
return render(request, self.object_history_template, context, **extra_kwargs)
96+
return self.render_history_view(
97+
request, self.object_history_template, context, **extra_kwargs
98+
)
9799

98100
def response_change(self, request, obj):
99101
if "_change_history" in request.POST and SIMPLE_HISTORY_EDIT:
@@ -196,10 +198,14 @@ def history_form_view(self, request, object_id, version_id, extra_context=None):
196198
context.update(self.admin_site.each_context(request))
197199
context.update(extra_context or {})
198200
extra_kwargs = {}
199-
return render(
201+
return self.render_history_view(
200202
request, self.object_history_form_template, context, **extra_kwargs
201203
)
202204

205+
def render_history_view(self, request, template, context, **kwargs):
206+
"""Catch call to render, to allow overriding."""
207+
return render(request, template, context, **kwargs)
208+
203209
def save_model(self, request, obj, form, change):
204210
"""Set special model attribute to user for reference after save"""
205211
obj._history_user = request.user

0 commit comments

Comments
 (0)