Skip to content

Commit d53d25b

Browse files
committed
Update docs, remove unused code
1 parent 12f515b commit d53d25b

File tree

8 files changed

+19
-42
lines changed

8 files changed

+19
-42
lines changed

CHANGES.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@ Changes
44
tip (unreleased)
55
----------------
66
- Add Polish locale.
7+
- Add Django 1.10 support.
78

89
1.8.1 (2016-03-19)
910
------------------

docs/usage.rst

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ settings:
3737

3838
.. code-block:: python
3939
40-
MIDDLEWARE_CLASSES = [
40+
MIDDLEWARE = [
4141
# ...
4242
'simple_history.middleware.HistoryRequestMiddleware',
4343
]
@@ -168,5 +168,6 @@ records for all ``Choice`` instances can be queried by using the manager on the
168168
<simple_history.manager.HistoryManager object at 0x1cc4290>
169169
>>> Choice.history.all()
170170
[<HistoricalChoice: Choice object as of 2010-10-25 18:05:12.183340>, <HistoricalChoice: Choice object as of 2010-10-25 18:04:59.047351>]
171-
172-
Because the history is model, you can also filter it like regulary QuerySets, a.k. Choice.history.filter(choice_text='Not Much') will work!
171+
172+
Because the history is model, you can also filter it like regularly QuerySets,
173+
a.k. Choice.history.filter(choice_text='Not Much') will work!

runtests.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
#!/usr/bin/env python
22
import logging
3-
from os import listdir, unlink
43
from os.path import abspath, dirname, join
54
from shutil import rmtree
65
import sys

setup.py

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@
22
import simple_history
33

44
tests_require = [
5-
'Django>=1.4', 'WebTest==2.0.18', 'django-webtest==1.7.8', 'mock==1.0.1']
6-
try:
7-
from unittest import skipUnless # noqa
8-
except ImportError: # Python 2.6 compatibility
9-
tests_require.append("unittest2")
5+
'Django>=1.6', 'WebTest==2.0.24', 'django-webtest==1.8.0', 'mock==1.0.1']
106

117
setup(
128
name='django-simple-history',
@@ -29,7 +25,6 @@
2925
"Environment :: Web Environment",
3026
"Intended Audience :: Developers",
3127
"Programming Language :: Python",
32-
"Programming Language :: Python :: 2.6",
3328
"Programming Language :: Python :: 2.7",
3429
'Programming Language :: Python :: 3',
3530
'Programming Language :: Python :: 3.2',

simple_history/templatetags/simple_history_compat.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
from django import template
2-
3-
try: # Django < 1.5
4-
from django.templatetags.future import url
5-
except ImportError:
6-
from django.template.defaulttags import url
2+
from django.template.defaulttags import url
73

84
register = template.Library()
95

simple_history/tests/models.py

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
from __future__ import unicode_literals
22

3-
import django
43
from django.db import models
54

65
from simple_history.models import HistoricalRecords
76
from simple_history import register
87

9-
if django.VERSION >= (1, 5):
10-
from .custom_user.models import CustomUser as User
11-
else: # django 1.4 compatibility
12-
from django.contrib.auth.models import User
8+
from .custom_user.models import CustomUser as User
139

1410

1511
class Poll(models.Model):

simple_history/tests/tests/test_admin.py

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8,23 +8,19 @@
88
from django.test.client import RequestFactory
99
from django.core.urlresolvers import reverse
1010
from django.conf import settings
11+
from django.contrib.auth import get_user_model
1112
from django.utils.encoding import force_text
1213

13-
try:
14-
from django.contrib.auth import get_user_model
15-
User = get_user_model()
16-
except ImportError: # Django < 1.5
17-
from django.contrib.auth.models import User
18-
try:
19-
from django.contrib.admin.utils import quote
20-
except ImportError: # Django < 1.7
21-
from django.contrib.admin.util import quote
22-
2314
from simple_history.models import HistoricalRecords
2415
from simple_history.admin import SimpleHistoryAdmin, get_complete_version
2516
from ..models import Book, Person, Poll, State, Employee
2617

18+
try:
19+
from django.contrib.admin.utils import quote
20+
except ImportError: # Django < 1.7
21+
from django.contrib.admin.util import quote
2722

23+
User = get_user_model()
2824
today = datetime(2021, 1, 1, 10, 0)
2925
tomorrow = today + timedelta(days=1)
3026

simple_history/tests/tests/test_models.py

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,11 @@
55
import warnings
66

77
import django
8+
from django.contrib.auth import get_user_model
9+
from django.core.files.base import ContentFile
810
from django.db import models
911
from django.db.models.fields.proxy import OrderWrt
1012
from django.test import TestCase
11-
from django.core.files.base import ContentFile
1213

1314
from simple_history.models import HistoricalRecords, convert_auto_field
1415
from ..models import (
@@ -28,16 +29,8 @@
2829
from django.db.models import get_model
2930
else:
3031
get_model = apps.get_model
31-
try:
32-
from unittest import skipUnless
33-
except ImportError:
34-
from unittest2 import skipUnless
35-
try:
36-
from django.contrib.auth import get_user_model
37-
User = get_user_model()
38-
except ImportError: # django 1.4 compatibility
39-
from django.contrib.auth.models import User
4032

33+
User = get_user_model()
4134
today = datetime(2021, 1, 1, 10, 0)
4235
tomorrow = today + timedelta(days=1)
4336
yesterday = today - timedelta(days=1)
@@ -499,7 +492,7 @@ def test_string_related(self):
499492
related_model = field_object.related.model
500493
self.assertEqual(related_model, HistoricalState)
501494

502-
@skipUnless(django.get_version() >= "1.7", "Requires 1.7 migrations")
495+
@unittest.skipUnless(django.get_version() >= "1.7", "Requires 1.7 migrations")
503496
def test_state_serialization_of_customfk(self):
504497
from django.db.migrations import state
505498
state.ModelState.from_model(HistoricalCustomFKError)
@@ -651,7 +644,7 @@ def test_restore_object_with_changed_order(self):
651644
self.assertEqual(order[5], self.w_chair.pk)
652645
self.assertEqual(order[6], self.w_battle.pk)
653646

654-
@skipUnless(django.get_version() >= "1.7", "Requires 1.7 migrations")
647+
@unittest.skipUnless(django.get_version() >= "1.7", "Requires 1.7 migrations")
655648
def test_migrations_include_order(self):
656649
from django.db.migrations import state
657650
model_state = state.ModelState.from_model(SeriesWork.history.model)

0 commit comments

Comments
 (0)