Renamed admin's action_list to historical_records

This is a more accurate name for the contents of the queryset.

Also did a small cleanup of `_object_history_list.html`, incl. removing
the `scope` attribute of a `<td>` tag, as it's been deprecated for those
tags (see
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/td#scope).

Author: ddabble

simple_history/admin.py

@@ -46,29 +46,29 @@ def history_view(self, request, object_id, extra_context=None):
         pk_name = opts.pk.attname
         history = getattr(model, model._meta.simple_history_manager_attribute)
         object_id = unquote(object_id)
-        action_list = history.filter(**{pk_name: object_id})
+        historical_records = history.filter(**{pk_name: object_id})
         if not isinstance(history.model.history_user, property):
             # Only select_related when history_user is a ForeignKey (not a property)
-            action_list = action_list.select_related("history_user")
+            historical_records = historical_records.select_related("history_user")
         history_list_display = getattr(self, "history_list_display", [])
         # If no history was found, see whether this object even exists.
         try:
             obj = self.get_queryset(request).get(**{pk_name: object_id})
         except model.DoesNotExist:
             try:
-                obj = action_list.latest("history_date").instance
-            except action_list.model.DoesNotExist:
+                obj = historical_records.latest("history_date").instance
+            except historical_records.model.DoesNotExist:
                 raise http.Http404
 
         if not self.has_view_history_or_change_history_permission(request, obj):
             raise PermissionDenied
 
-        # Set attribute on each action_list entry from admin methods
+        # Set attribute on each historical record from admin methods
         for history_list_entry in history_list_display:
             value_for_entry = getattr(self, history_list_entry, None)
             if value_for_entry and callable(value_for_entry):
-                for list_entry in action_list:
-                    setattr(list_entry, history_list_entry, value_for_entry(list_entry))
+                for record in historical_records:
+                    setattr(record, history_list_entry, value_for_entry(record))
 
         content_type = self.content_type_model_cls.objects.get_for_model(
             get_user_model()
@@ -80,7 +80,7 @@ def history_view(self, request, object_id, extra_context=None):
         )
         context = {
             "title": self.history_view_title(request, obj),
-            "action_list": action_list,
+            "historical_records": historical_records,
             "module_name": capfirst(force_str(opts.verbose_name_plural)),
             "object": obj,
             "root_path": getattr(self.admin_site, "root_path", None),

simple_history/templates/simple_history/_object_history_list.html

@@ -17,28 +17,32 @@
     </tr>
   </thead>
   <tbody>
-    {% for action in action_list %}
+    {% for record in historical_records %}
       <tr>
-        <td><a href="{% url opts|admin_urlname:'simple_history' object.pk action.pk %}">{{ action.history_object }}</a></td>
+        <td>
+          <a href="{% url opts|admin_urlname:'simple_history' object.pk record.pk %}">
+            {{ record.history_object }}
+          </a>
+        </td>
         {% for column in history_list_display %}
-        <td scope="col">{{ action|getattribute:column }}</th>
+          <td>{{ record|getattribute:column }}</td>
         {% endfor %}
-        <td>{{ action.history_date }}</td>
-        <td>{{ action.get_history_type_display }}</td>
+        <td>{{ record.history_date }}</td>
+        <td>{{ record.get_history_type_display }}</td>
         <td>
-          {% if action.history_user %}
-            {% url admin_user_view action.history_user_id as admin_user_url %}
+          {% if record.history_user %}
+            {% url admin_user_view record.history_user_id as admin_user_url %}
             {% if admin_user_url %}
-              <a href="{{ admin_user_url }}">{{ action.history_user }}</a>
+              <a href="{{ admin_user_url }}">{{ record.history_user }}</a>
             {% else %}
-              {{ action.history_user }}
+              {{ record.history_user }}
             {% endif %}
           {% else %}
             {% trans "None" %}
           {% endif %}
         </td>
         <td>
-            {{ action.history_change_reason }}
+          {{ record.history_change_reason }}
         </td>
       </tr>
     {% endfor %}

simple_history/templates/simple_history/object_history.html

@@ -10,7 +10,7 @@
     {% if not revert_disabled %}<p>
       {% blocktrans %}Choose a date from the list below to revert to a previous version of this object.{% endblocktrans %}</p>{% endif %}
     <div class="module">
-      {% if action_list %}
+      {% if historical_records %}
         {% display_list %}
       {% else %}
         <p>{% trans "This object doesn't have a change history." %}</p>