add unit tests for verbose name plural

Author: sridhar

simple_history/registry_tests/migration_test_app/migrations/0007_alter_historicalmodelwithcustomattrforeignkey_options_and_more.py

@@ -0,0 +1,25 @@
+# Generated by Django 4.0.1 on 2022-01-28 11:26
+
+from django.db import migrations
+
+
+class Migration(migrations.Migration):
+
+    dependencies = [
+        ('migration_test_app', '0006_alter_historicalmodelwithcustomattronetoonefield_options_and_more'),
+    ]
+
+    operations = [
+        migrations.AlterModelOptions(
+            name='historicalmodelwithcustomattrforeignkey',
+            options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical model with custom attr foreign key', 'verbose_name_plural': 'historical model with custom attr foreign keys'},
+        ),
+        migrations.AlterModelOptions(
+            name='historicalmodelwithcustomattronetoonefield',
+            options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical model with custom attr one to one field', 'verbose_name_plural': 'historical model with custom attr one to one fields'},
+        ),
+        migrations.AlterModelOptions(
+            name='historicalyar',
+            options={'get_latest_by': ('history_date', 'history_id'), 'ordering': ('-history_date', '-history_id'), 'verbose_name': 'historical yar', 'verbose_name_plural': 'historical yars'},
+        ),
+    ]

simple_history/tests/models.py

@@ -291,7 +291,9 @@ class State(models.Model):
 
 class Book(models.Model):
     isbn = models.CharField(max_length=15, primary_key=True)
-    history = HistoricalRecords(verbose_name="dead trees")
+    history = HistoricalRecords(
+        verbose_name="dead trees", verbose_name_plural="dead trees plural"
+    )
 
 
 class HardbackBook(Book):
@@ -308,6 +310,7 @@ class Library(models.Model):
 
     class Meta:
         verbose_name = "quiet please"
+        verbose_name_plural = "quiet please plural"
 
 
 class BaseModel(models.Model):
@@ -377,6 +380,14 @@ class Meta:
         verbose_name = "\u570b"
 
 
+class UnicodeVerboseNamePlural(models.Model):
+    name = models.CharField(max_length=100)
+    history = HistoricalRecords()
+
+    class Meta:
+        verbose_name_plural = "\u570b"
+
+
 class CustomFKError(models.Model):
     fk = models.ForeignKey(SecondLevelInheritedModel, on_delete=models.CASCADE)
     history = HistoricalRecords()

simple_history/tests/tests/test_models.py

@@ -91,6 +91,7 @@
     Street,
     Temperature,
     UnicodeVerboseName,
+    UnicodeVerboseNamePlural,
     UserTextFieldChangeReasonModel,
     UUIDDefaultModel,
     UUIDModel,
@@ -510,6 +511,28 @@ def test_historical_verbose_name_follows_model_verbose_name(self):
             "historical quiet please", library.history.get()._meta.verbose_name
         )
 
+    def test_unicode_verbose_name_plural(self):
+        instance = UnicodeVerboseNamePlural()
+        instance.save()
+        self.assertEqual(
+            "historical \u570b", instance.history.all()[0]._meta.verbose_name_plural
+        )
+
+    def test_user_can_set_verbose_name_plural(self):
+        b = Book(isbn="54321")
+        b.save()
+        self.assertEqual(
+            "dead trees plural", b.history.all()[0]._meta.verbose_name_plural
+        )
+
+    def test_historical_verbose_name_plural_follows_model_verbose_name_plural(self):
+        library = Library()
+        library.save()
+        self.assertEqual(
+            "historical quiet please plural",
+            library.history.get()._meta.verbose_name_plural
+        )
+
     def test_foreignkey_primarykey(self):
         """Test saving a tracked model with a `ForeignKey` primary key."""
         poll = Poll(pub_date=today)