Skip to content

Commit 91242ff

Browse files
committed
implement #87
1 parent fbf0294 commit 91242ff

File tree

306 files changed

+639
-705
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

306 files changed

+639
-705
lines changed

CONTRIBUTING.md

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -12,31 +12,21 @@
1212

1313
# Contributing
1414

15-
Contributions are encouraged! Please use the issue page to submit feature
16-
requests or bug reports. Issues with attached PRs will be given priority and
17-
have a much higher likelihood of acceptance. Please also open an issue and
18-
associate it with any submitted PRs. That said, the aim is to keep this library
19-
as lightweight as possible. Only features with broad-based use cases will be
20-
considered.
15+
Contributions are encouraged! Please use the issue page to submit feature requests or bug reports. Issues with attached PRs will be given priority and have a much higher likelihood of acceptance. Please also open an issue and associate it with any submitted PRs. That said, the aim is to keep this library as lightweight as possible. Only features with broad-based use cases will be considered.
2116

22-
We are actively seeking additional maintainers. If you're interested, please
23-
[contact me](https://github.com/bckohan).
17+
We are actively seeking additional maintainers. If you're interested, please [contact me](https://github.com/bckohan).
2418

2519
## Installation
2620

27-
`django-typer` uses [Poetry](https://python-poetry.org/) for environment, package, and dependency
28-
management:
21+
`django-typer` uses [Poetry](https://python-poetry.org/) for environment, package, and dependency management:
2922

3023
```shell
3124
poetry install
3225
```
3326

3427
## Documentation
3528

36-
`django-typer` documentation is generated using [Sphinx](https://www.sphinx-doc.org/en/master/) with the
37-
[readthedocs](https://readthedocs.org/) theme. Any new feature PRs must provide updated documentation for
38-
the features added. To build the docs run doc8 to check for formatting issues
39-
then run Sphinx:
29+
`django-typer` documentation is generated using [Sphinx](https://www.sphinx-doc.org/en/master/) with the [readthedocs](https://readthedocs.org/) theme. Any new feature PRs must provide updated documentation for the features added. To build the docs run doc8 to check for formatting issues then run Sphinx:
4030

4131
```bash
4232
cd ./doc
@@ -46,11 +36,7 @@ poetry run make html
4636

4737
## Static Analysis
4838

49-
`django-typer` uses [ruff](https://docs.astral.sh/ruff/) for Python linting, header import
50-
standardization and code formatting. [mypy](http://mypy-lang.org/) and
51-
[pyright](https://github.com/microsoft/pyright) are used for static type checking. Before any PR
52-
is accepted the following must be run, and static analysis tools should not produce any errors or
53-
warnings. Disabling certain errors or warnings where justified is acceptable:
39+
`django-typer` uses [ruff](https://docs.astral.sh/ruff/) for Python linting, header import standardization and code formatting. [mypy](http://mypy-lang.org/) and [pyright](https://github.com/microsoft/pyright) are used for static type checking. Before any PR is accepted the following must be run, and static analysis tools should not produce any errors or warnings. Disabling certain errors or warnings where justified is acceptable:
5440

5541
```bash
5642
./check.sh
@@ -64,10 +50,7 @@ To run static analysis without automated fixing you can run:
6450

6551
## Running Tests
6652

67-
`django-typer` is set up to use [pytest](https://docs.pytest.org/en/stable/) to run unit tests. All the tests are
68-
housed in `django_typer/tests/tests.py`. Before a PR is accepted, all tests
69-
must be passing and the code coverage must be at 100%. A small number of
70-
exempted error handling branches are acceptable.
53+
`django-typer` is set up to use [pytest](https://docs.pytest.org/en/stable/) to run unit tests. All the tests are housed in `tests/tests.py`. Before a PR is accepted, all tests must be passing and the code coverage must be at 100%. A small number of exempted error handling branches are acceptable.
7154

7255
To run the full suite:
7356

@@ -81,10 +64,9 @@ To run a single test, or group of tests in a class:
8164
poetry run pytest <path_to_tests_file>::ClassName::FunctionName
8265
```
8366

84-
For instance, to run all tests in BasicTests, and then just the
85-
test_call_command test you would do:
67+
For instance, to run all tests in BasicTests, and then just the test_call_command test you would do:
8668

8769
```shell
88-
poetry run pytest django_typer/tests/tests.py::BasicTests
89-
poetry run pytest django_typer/tests/tests.py::BasicTests::test_call_command
70+
poetry run pytest tests/tests.py::BasicTests
71+
poetry run pytest tests/tests.py::BasicTests::test_call_command
9072
```

django_typer/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2487,7 +2487,7 @@ def command2(self, option: t.Optional[str] = None):
24872487
24882488
We can see that our help renders like so:
24892489
2490-
.. typer:: django_typer.tests.apps.test_app.management.commands.chain.Command:typer_app
2490+
.. typer:: tests.apps.test_app.management.commands.chain.Command:typer_app
24912491
:prog: ./manage.py chain
24922492
:width: 80
24932493
:convert-png: latex

django_typer/tests/apps/examples

Lines changed: 0 additions & 1 deletion
This file was deleted.

django_typer/tests/backup.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

django_typer/tests/examples.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

django_typer/tests/howto.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

django_typer/tests/manage.py

Lines changed: 0 additions & 26 deletions
This file was deleted.

django_typer/tests/settings/adapted.py

Lines changed: 0 additions & 7 deletions
This file was deleted.

django_typer/tests/settings/adapted1.py

Lines changed: 0 additions & 8 deletions
This file was deleted.

django_typer/tests/settings/adapted1_2.py

Lines changed: 0 additions & 9 deletions
This file was deleted.

0 commit comments

Comments
 (0)