fix #75

Author: Brian Kohan

CONTRIBUTING.md

@@ -53,14 +53,13 @@ is accepted the following must be run, and static analysis tools should not prod
 warnings. Disabling certain errors or warnings where justified is acceptable:
 
 ```bash
-poetry run ruff format django_typer
-poetry run ruff check --fix --select I django_typer
-poetry run ruff check django_typer
-poetry run mypy django_typer
-pyright
-poetry check
-poetry run pip check
-poetry run python -m readme_renderer ./README.md
+./check.sh
+```
+
+To run static analysis without automated fixing you can run:
+
+```bash
+./check.sh --no-fix
 ```
 
 ## Running Tests

README.md

@@ -220,9 +220,7 @@ Using the class-based interface we could define the command like this:
 
 ```
 
-The typer-style interface builds a TyperCommand class for us. This allows you to optionally 
-accept the self argument in your commands. We could define the above command using the typer
-interface like this:
+The typer-style interface builds a TyperCommand class for us. **This allows you to optionally accept the self argument in your commands.** We could define the above command using the typer interface like this:
 
 ```python
 

django_typer/management/commands/shellcompletion.py

@@ -589,7 +589,7 @@ def get_completion() -> None:
                                 cmd_str=cmd_str
                             )
                         ) from err
-                    raise  # otherwise nowhere to go
+                    return  # otherwise nowhere to go
 
                 if isinstance(cmd, TyperCommand):  # type: ignore[unreachable]
                     # this will exit out so no return is needed here

django_typer/tests/conftest.py

@@ -1,6 +1,6 @@
 # conftest.py
 def pytest_collection_modifyitems(items):
-    """Modifies test items in place to ensure test modules run in a given order."""
+    """Modifies test items in place to ensure plugin tests run in a specific order."""
     sorted_tests = []
     interference_tests = []
     plugin_tests = []  # push these to the back

django_typer/tests/shellcompletion/__init__.py

@@ -143,6 +143,7 @@ def read(fd):
         os.write(master_fd, (" ".join(cmds)).encode())
         time.sleep(0.5)
 
+        print(f'"{(" ".join(cmds))}"')
         os.write(master_fd, b"\t\t")
 
         time.sleep(0.5)
@@ -160,7 +161,8 @@ def read(fd):
         os.close(master_fd)
         process.terminate()
         process.wait()
-        return output
+        # remove bell character which can show up in some terminals where we hit tab
+        return output.replace("\x07", "")
 
     def run_app_completion(self):
         completions = self.get_completions(self.launch_script, "completion", " ")
@@ -173,7 +175,7 @@ def run_app_completion(self):
         self.assertIn("staticfiles", completions)
 
     def run_command_completion(self):
-        completions = self.get_completions(self.launch_script, "complet", "")
+        completions = self.get_completions(self.launch_script, "complet")
         self.assertIn("completion", completions)
         completions = self.get_completions(self.launch_script, " ")
         self.assertIn("makemigrations", completions)

doc/source/changelog.rst

@@ -8,6 +8,7 @@ v2.0.0
 This major version release, includes an extensive internal refactor, numerous bug fixes and the
 addition of a plugin-based extension pattern.
 
+* Fixed `Stack trace produced when attempted to tab-complete a non-existent management command. <https://github.com/bckohan/django-typer/issues/75>`_
 * Fixed `Overriding handle() in inherited commands results in multiple commands. <https://github.com/bckohan/django-typer/issues/74>`_
 * Implemented `Support subgroup name overloads. <https://github.com/bckohan/django-typer/issues/70>`_
 * Fixed `Helps from class docstrings and TyperCommand class parameters are not inherited. <https://github.com/bckohan/django-typer/issues/69>`_