fix handle() rename bug, flush out howto docs

Author: bckohan

django_typer/__init__.py

@@ -859,8 +859,8 @@ def decorator(func: CommandFunctionType):
         setattr(
             func,
             "_typer_callback_",
-            lambda cmd, **extra: cmd.typer_app.callback(
-                name=name or extra.pop("name", None),
+            lambda cmd, _name=None, **extra: cmd.typer_app.callback(
+                name=name or _name,
                 cls=type("_AdaptedCallback", (cls,), {"django_command": cmd}),
                 invoke_without_command=invoke_without_command,
                 subcommand_metavar=subcommand_metavar,
@@ -962,8 +962,8 @@ def decorator(func: CommandFunctionType):
         setattr(
             func,
             "_typer_command_",
-            lambda cmd, **extra: cmd.typer_app.command(
-                name=name or extra.pop("name", None),
+            lambda cmd, _name=None, **extra: cmd.typer_app.command(
+                name=name or _name,
                 *args,
                 cls=type("_AdaptedCommand", (cls,), {"django_command": cmd}),
                 context_settings=context_settings,
@@ -1290,7 +1290,7 @@ def get_ctor(attr: str) -> t.Optional[t.Callable[..., t.Any]]:
                 if cmd_cls._handle:
                     ctor = get_ctor(cmd_cls._handle)
                     if ctor:
-                        ctor(cls, name=cls.typer_app.info.name)
+                        ctor(cls, _name=cls.typer_app.info.name)
                     else:
                         cls._num_commands += 1
                         cls.typer_app.command(

django_typer/tests/test_app/management/commands/howto1.py

@@ -0,0 +1,28 @@
+import typing as t
+
+from typer import Argument, Option
+
+from django_typer import TyperCommand, command
+
+
+class Command(TyperCommand):
+
+    @command()
+    def option1(self, flag: bool = False):
+        pass
+
+    @command()
+    def option2(self, name: str = "world"):
+        pass
+
+    @command()
+    def option3(self, name: t.Annotated[str, Option(help="The name of the thing")]):
+        pass
+
+    @command()
+    def arg1(self, int_arg: int):
+        pass
+
+    @command()
+    def arg2(self, int_arg: t.Annotated[int, Argument(help="An integer argument")]):
+        pass

django_typer/tests/test_app/management/commands/howto2.py

@@ -0,0 +1,13 @@
+from django_typer import TyperCommand, command
+
+
+class Command(TyperCommand):
+
+    @command(name="subcommand1")
+    def handle(self): ...
+
+    @command()
+    def subcommand2(self): ...
+
+    @command()
+    def subcommand3(self): ...

django_typer/tests/test_app/management/commands/rename.py

@@ -0,0 +1,16 @@
+from django_typer import TyperCommand, command
+
+
+class Command(TyperCommand):
+
+    @command(name="default")
+    def handle(self):
+        return "handle"
+
+    @command(name="renamed")
+    def subcommand1(self):
+        return "subcommand1"
+
+    @command("renamed2")
+    def subcommand2(self):
+        return "subcommand2"

django_typer/tests/tests.py

@@ -168,6 +168,19 @@ def test_command_context(self):
             self.assertEqual(basic, get_current_command())
         self.assertIsNone(get_current_command())
 
+    def test_renaming(self):
+        self.assertEqual(run_command("rename", "default")[0].strip(), "handle")
+        self.assertEqual(run_command("rename", "renamed")[0].strip(), "subcommand1")
+        self.assertEqual(run_command("rename", "renamed2")[0].strip(), "subcommand2")
+
+        self.assertEqual(call_command("rename", "default"), "handle")
+        self.assertEqual(call_command("rename", "renamed"), "subcommand1")
+        self.assertEqual(call_command("rename", "renamed2"), "subcommand2")
+
+        self.assertEqual(get_command("rename")(), "handle")
+        self.assertEqual(get_command("rename").subcommand1(), "subcommand1")
+        self.assertEqual(get_command("rename").subcommand2(), "subcommand2")
+
 
 class CommandDefinitionTests(TestCase):
     def test_group_callback_throws(self):