add test for #75, simplify BFS for tree structures, tests for coverage

Author: bckohan

check.sh

@@ -13,7 +13,7 @@ else
 fi
 
 poetry run mypy django_typer
-pyright
+poetry run pyright
 poetry check
 poetry run pip check
 cd ./doc

django_typer/__init__.py

@@ -1768,9 +1768,6 @@ def _names(tc: t.Union[typer.models.CommandInfo, Typer]) -> t.List[str]:
             names.append(tc.name)
         if tc.info.name and tc.info.name != tc.name:
             names.append(tc.info.name)
-        cb_name = getattr(tc.info.callback, "__name__", None)
-        if cb_name and cb_name not in names:
-            names.append(cb_name)
     return names
 
 
@@ -1799,24 +1796,21 @@ def find_at_level(
     if found := find_at_level(app):
         return found
 
-    visited = set()
     bfs_order: t.List[Typer] = []
     queue = deque([app])
 
     while queue:
         grp = queue.popleft()
-        if grp not in visited:
-            visited.add(grp)
-            bfs_order.append(grp)
-            # if names conflict, only pick the first the others have been
-            # overridden - avoids walking down stale branches
-            seen = []
-            for child_grp in reversed(grp.registered_groups):
-                child_app = t.cast(Typer, child_grp.typer_instance)
-                assert child_app
-                if child_app not in visited and child_app.name not in seen:
-                    seen.extend(_names(child_app))
-                    queue.append(child_app)
+        bfs_order.append(grp)
+        # if names conflict, only pick the first the others have been
+        # overridden - avoids walking down stale branches
+        seen = []
+        for child_grp in reversed(grp.registered_groups):
+            child_app = t.cast(Typer, child_grp.typer_instance)
+            assert child_app
+            if child_app.name not in seen:
+                seen.extend(_names(child_app))
+                queue.append(child_app)
 
     for grp in bfs_order[1:]:
         found = find_at_level(grp)
@@ -1968,7 +1962,7 @@ def command_bases() -> t.Generator[t.Type[TyperCommand], None, None]:
                         yield base
 
             typer_app = Typer(
-                name=name or attrs["__module__"].rsplit(".", maxsplit=1)[-1],
+                name=name or attrs.get("__module__", "").rsplit(".", maxsplit=1)[-1],
                 cls=kwargs.pop("cls", DTGroup),
                 help=help or attr_help,  # pyright: ignore[reportArgumentType]
                 invoke_without_command=invoke_without_command,

django_typer/tests/shellcompletion/__init__.py

@@ -181,6 +181,13 @@ def run_app_completion(self):
         self.assertIn("sessions", completions)
         self.assertIn("staticfiles", completions)
 
+    def run_bad_command_completion(self):
+        completions = self.get_completions(
+            self.launch_script, "completion_does_not_exist", " "
+        )
+        self.assertTrue("Exception" not in completions)
+        self.assertTrue("traceback" not in completions)
+
     def run_command_completion(self):
         completions = self.get_completions(self.launch_script, "complet")
         # annoingly in CI there are some spaces inserted between the incomplete phrase
@@ -197,6 +204,7 @@ def test_shell_complete(self):
             self.run_app_completion()
         self.install()
         self.run_app_completion()
+        self.run_bad_command_completion()
         self.run_command_completion()
         self.remove()
         with self.assertRaises(AssertionError):

django_typer/tests/test_interface.py

@@ -324,3 +324,6 @@ def sqrt():
 
         with self.assertRaises(AttributeError):
             TyperCommandMeta.maths
+
+        with self.assertRaises(AttributeError):
+            TyperCommandMeta("dummy", tuple(), {}).maths