Skip to content

Commit 09a9189

Browse files
committed
add a todo comment
1 parent 29ec776 commit 09a9189

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/tests_async/test_requests.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ def setup(self):
2020
signals.request_finished.connect(close_async_caches)
2121

2222
def test_old_receiver_is_registered_and_new_receiver_unregistered(self, setup):
23-
sync_receivers, async_receivers = signals.request_finished._live_receivers(None)
23+
sync_receivers, async_receivers = signals.request_finished._live_receivers(
24+
None)
2425
assert close_caches in sync_receivers
2526
assert close_async_caches not in async_receivers
2627

@@ -45,7 +46,8 @@ async def test_manually_await_signal(self, recwarn):
4546
== "coroutine 'AsyncBackendCommands.close' was never awaited"
4647
)
4748

48-
# for some reason if i make this function sync, it can't get the log
49+
# TODO: find why garbage collector doesn't collect the coroutine when the method is
50+
# sync (even when gc is called manually, it doesn't collect)
4951
async def test_manually_call_signal(self):
5052
with pytest.warns(
5153
RuntimeWarning,
@@ -75,7 +77,8 @@ def test_manually_call_signal(self, recwarn):
7577
assert len(recwarn) == 0
7678

7779
def test_receiver_is_registered_and_old_receiver_unregistered(self):
78-
sync_receivers, async_receivers = signals.request_finished._live_receivers(None)
80+
sync_receivers, async_receivers = signals.request_finished._live_receivers(
81+
None)
7982
assert close_async_caches in async_receivers
8083
assert close_caches not in sync_receivers
8184

0 commit comments

Comments
 (0)