add test for the new shard logic

(cherry picked from commit 1ea3331)

Author: amirreza8002

tests/test_client.py

@@ -128,17 +128,56 @@ def test_delete_pattern_calls_pipeline_delete_and_execute(
 
 
 class TestShardClient:
-    @patch("tests.test_client.DefaultClient.make_pattern")
+    CLIENT_METHODS_FOR_MOCK = {
+        "add",
+        "close",
+        "expire",
+        "get",
+        "ttl",
+        "touch",
+        "sadd",
+        "scan_iter",
+        "spop",
+    }
+
+    @pytest.fixture
+    def shard_cache(self):
+        from django.core.cache import caches, ConnectionProxy
+
+        cache = ConnectionProxy(caches, "default")
+        yield cache
+        cache.clear()
+
+    @pytest.fixture
+    def connection(self, mocker):
+        connection = mocker.Mock()
+        for m in self.CLIENT_METHODS_FOR_MOCK:
+            setattr(connection, m, mocker.Mock(spec_set=()))
+
+        connection.scan_iter.return_value = []
+        connection.get.return_value = "this"
+        connection.add.return_value = True
+        connection.expire.return_value = False
+        connection.close.return_value = None
+        connection.ttl.return_value = 0
+        connection.touch.return_value = True
+        connection.sadd.return_value = 1
+        connection.spop.return_value = {"this"}
+
+        yield connection
+
+    @patch("tests.test_client.ShardClient.make_pattern")
     @patch("tests.test_client.ShardClient.__init__", return_value=None)
     def test_delete_pattern_calls_scan_iter_with_count_if_itersize_given(
-        self, init_mock, make_pattern_mock
+        self,
+        init_mock,
+        make_pattern_mock,
+        connection,
     ):
         client = ShardClient()
         client._backend = Mock()
         client._backend.key_prefix = ""
 
-        connection = Mock()
-        connection.scan_iter.return_value = []
         client._server_dict = {"test": connection}
 
         client.delete_pattern(pattern="foo*", itersize=10)
@@ -147,14 +186,14 @@ def test_delete_pattern_calls_scan_iter_with_count_if_itersize_given(
             count=10, match=make_pattern_mock.return_value
         )
 
-    @patch("tests.test_client.DefaultClient.make_pattern")
+    @patch("tests.test_client.ShardClient.make_pattern")
     @patch("tests.test_client.ShardClient.__init__", return_value=None)
-    def test_delete_pattern_calls_scan_iter(self, init_mock, make_pattern_mock):
+    def test_delete_pattern_calls_scan_iter(
+        self, init_mock, make_pattern_mock, connection
+    ):
         client = ShardClient()
         client._backend = Mock()
         client._backend.key_prefix = ""
-        connection = Mock()
-        connection.scan_iter.return_value = []
         client._server_dict = {"test": connection}
 
         client.delete_pattern(pattern="foo*")
@@ -163,19 +202,37 @@ def test_delete_pattern_calls_scan_iter(self, init_mock, make_pattern_mock):
             match=make_pattern_mock.return_value
         )
 
-    @patch("tests.test_client.DefaultClient.make_pattern")
+    @patch("tests.test_client.ShardClient.make_pattern")
     @patch("tests.test_client.ShardClient.__init__", return_value=None)
     def test_delete_pattern_calls_delete_for_given_keys(
-        self, init_mock, make_pattern_mock
+        self, init_mock, make_pattern_mock, connection, cache
     ):
         client = ShardClient()
         client._backend = Mock()
         client._backend.key_prefix = ""
-        connection = Mock()
         connection.scan_iter.return_value = [Mock(), Mock()]
         connection.delete.return_value = 0
         client._server_dict = {"test": connection}
 
         client.delete_pattern(pattern="foo*")
 
         connection.delete.assert_called_once_with(*connection.scan_iter.return_value)
+
+    def test_shard_client_get_server_name_is_called(
+        self, mocker, connection, shard_cache
+    ):
+        if not isinstance(shard_cache.client, ShardClient):
+            pytest.skip("shard only test")
+        client = ShardClient(
+            server=shard_cache._server, params=shard_cache._params, backend=shard_cache
+        )
+        spy = mocker.spy(client, "get_server_name")
+
+        client.add("that", "this")
+        client.get("that")
+        client.ttl("that")
+        client.expire("that", 1)
+        client.touch("that")
+        client.sadd("key", "value1", "value2")
+        client.spop("key")
+        assert spy.call_count == 7