Skip to content

Commit dec89af

Browse files
slivercmblayman
authored andcommitted
Enforcing of flake8 linter (#348)
* Enforcing of flake8 linter * Allow F405 (star imports) as this is part of drf json api concept * Remove E501 so defined max-line-length won't be ignored * Adjusted changelog and authors
1 parent 76b60fe commit dec89af

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

42 files changed

+403
-195
lines changed

.travis.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,11 +40,12 @@ before_install:
4040
# Force an upgrade of py & pytest to avoid VersionConflict
4141
- pip install --upgrade py
4242
- pip install "pytest>=2.8,<3"
43-
- pip install codecov
43+
- pip install codecov flake8
4444
install:
4545
- pip install Django${DJANGO} djangorestframework${DRF}
4646
- python setup.py install
4747
script:
48+
- flake8
4849
- coverage run setup.py -v test
4950
after_success:
5051
- codecov

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,5 @@ Jerel Unruh <[email protected]>
22
Greg Aker <[email protected]>
33
Adam Wróbel <https://adamwrobel.com>
44
Christian Zosel <https://zosel.ch>
5+
Oliver Sauder <[email protected]>
56

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ v2.3.0
55
and there was no way to turn it off.
66
* Fix for apps that don't use `django.contrib.contenttypes`.
77
* Fix `resource_name` support for POST requests and nested serializers
8+
* Enforcing flake8 linting
89

910
v2.2.0
1011

example/api/resources/identity.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ class GenericIdentity(generics.GenericAPIView):
5959
renderer_classes = (renderers.JSONRenderer, )
6060
parser_classes = (parsers.JSONParser, )
6161

62-
6362
def get_queryset(self):
6463
return auth_models.User.objects.all()
6564

example/api/serializers/identity.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,11 @@ class IdentitySerializer(serializers.ModelSerializer):
66
"""
77
Identity Serializer
88
"""
9+
910
def validate_first_name(self, data):
1011
if len(data) > 10:
1112
raise serializers.ValidationError(
12-
'There\'s a problem with first name')
13+
'There\'s a problem with first name')
1314
return data
1415

1516
def validate_last_name(self, data):

example/api/serializers/post.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,3 @@ class PostSerializer(serializers.Serializer):
66
Blog post serializer
77
"""
88
title = serializers.CharField(max_length=50)
9-

example/factories/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
faker = FakerFactory.create()
88
faker.seed(983843)
99

10+
1011
class BlogFactory(factory.django.DjangoModelFactory):
1112
class Meta:
1213
model = Blog
@@ -23,6 +24,7 @@ class Meta:
2324

2425
bio = factory.RelatedFactory('example.factories.AuthorBioFactory', 'author')
2526

27+
2628
class AuthorBioFactory(factory.django.DjangoModelFactory):
2729
class Meta:
2830
model = AuthorBio

example/models.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,4 +86,3 @@ class Comment(BaseModel):
8686

8787
def __str__(self):
8888
return self.body
89-

example/serializers.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ def get_copyright(self, resource):
2424

2525
def get_root_meta(self, resource, many):
2626
return {
27-
'api_docs': '/docs/api/blogs'
27+
'api_docs': '/docs/api/blogs'
2828
}
2929

3030
class Meta:
@@ -55,17 +55,17 @@ def __init__(self, *args, **kwargs):
5555
body_format = serializers.SerializerMethodField()
5656
# many related from model
5757
comments = relations.ResourceRelatedField(
58-
many=True, read_only=True)
58+
many=True, read_only=True)
5959
# many related from serializer
6060
suggested = relations.SerializerMethodResourceRelatedField(
61-
source='get_suggested', model=Entry, many=True, read_only=True,
62-
related_link_view_name='entry-suggested',
63-
related_link_url_kwarg='entry_pk',
64-
self_link_view_name='entry-relationships',
61+
source='get_suggested', model=Entry, many=True, read_only=True,
62+
related_link_view_name='entry-suggested',
63+
related_link_url_kwarg='entry_pk',
64+
self_link_view_name='entry-relationships',
6565
)
6666
# single related from serializer
6767
featured = relations.SerializerMethodResourceRelatedField(
68-
source='get_featured', model=Entry, read_only=True)
68+
source='get_featured', model=Entry, read_only=True)
6969
tags = TaggedItemSerializer(many=True, read_only=True)
7070

7171
def get_suggested(self, obj):

example/settings/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
from .dev import *
1+
from .dev import * # noqa

0 commit comments

Comments
 (0)