test: add missing unit test for user_code_generator

Author: cristiprg

oauth2_provider/utils.py

@@ -65,6 +65,8 @@ def user_code_generator(user_code_length: int = 8) -> str:
 
     for our function we'll be using a base 32 character set
     """
+    if user_code_length < 1:
+        raise ValueError("user_code_length needs to be greater than 0")
 
     # base32 character space
     character_space = "0123456789ABCDEFGHIJKLMNOPQRSTUV"

tests/test_utils.py

@@ -1,3 +1,5 @@
+import pytest
+
 from oauth2_provider import utils
 
 
@@ -25,3 +27,24 @@ def test_jwk_from_pem_caches_jwk():
     jwk3 = utils.jwk_from_pem(a_different_tiny_rsa_key)
 
     assert jwk3 is not jwk1
+
+
+def test_user_code_generator():
+    # Default argument, 8 characters
+    user_code = utils.user_code_generator()
+    assert isinstance(user_code, str)
+    assert len(user_code) == 8
+
+    for character in user_code:
+        assert character >= "0"
+        assert character <= "V"
+
+    another_user_code = utils.user_code_generator()
+    assert another_user_code != user_code
+
+    shorter_user_code = utils.user_code_generator(user_code_length=1)
+    assert len(shorter_user_code) == 1
+
+    with pytest.raises(ValueError):
+        utils.user_code_generator(user_code_length=0)
+        utils.user_code_generator(user_code_length=-1)