Skip to content

Commit 4990742

Browse files
committed
Fixed bug when authorization header doesnt contain any white spaces.
1 parent f187242 commit 4990742

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

oauth2_provider/oauth2_validators.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,11 @@ def _extract_basic_auth(self, request):
3636
if not auth:
3737
return None
3838

39-
auth_type, auth_string = auth.split(' ', 1)
39+
splitted = auth.split(' ', 1)
40+
if len(splitted) != 2:
41+
return None
42+
auth_type, auth_string = splitted
43+
4044
if auth_type != "Basic":
4145
return None
4246

oauth2_provider/tests/test_oauth2_validators.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ def test_extract_basic_auth(self):
4242
self.assertIsNone(self.validator._extract_basic_auth(self.request))
4343
self.request.headers = {'HTTP_AUTHORIZATION': 'Dummy 123456'}
4444
self.assertIsNone(self.validator._extract_basic_auth(self.request))
45+
self.request.headers = {'HTTP_AUTHORIZATION': 'Basic'}
46+
self.assertIsNone(self.validator._extract_basic_auth(self.request))
4547
self.request.headers = {'HTTP_AUTHORIZATION': 'Basic 123456 789'}
4648
self.assertEqual(self.validator._extract_basic_auth(self.request), '123456 789')
4749

0 commit comments

Comments
 (0)