Skip to content

Commit 70eaf47

Browse files
authored
Hotfix- authorization_code_expire_seconds docs clarified (#1212)
* Hotfix- authorization_code_expire_seconds docs clarified * Fix: Minor grammatical change
1 parent 6dc4f89 commit 70eaf47

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1616

1717
## [unreleased]
1818

19+
### Changed
20+
* #1211 documentation improve on 'AUTHORIZATION_CODE_EXPIRE_SECONDS'.
21+
1922
## [2.2.0] 2022-10-18
2023

2124
### WARNING
@@ -29,7 +32,6 @@ These issues both result in `{"error": "invalid_client"}`:
2932

3033
2. `PKCE_REQUIRED` is now `True` by default. You should use PKCE with your client or set `PKCE_REQUIRED=False` if you are unable to fix the client.
3134

32-
3335
### Added
3436
* #1208 Add 'code_challenge_method' parameter to authorization call in documentation
3537
* #1182 Add 'code_verifier' parameter to token requests in documentation

docs/settings.rst

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,12 @@ List of available settings
2929

3030
ACCESS_TOKEN_EXPIRE_SECONDS
3131
~~~~~~~~~~~~~~~~~~~~~~~~~~~
32+
33+
Default: ``36000``
34+
3235
The number of seconds an access token remains valid. Requesting a protected
3336
resource after this duration will fail. Keep this value high enough so clients
34-
can cache the token for a reasonable amount of time. (default: 36000)
37+
can cache the token for a reasonable amount of time.
3538

3639
ACCESS_TOKEN_MODEL
3740
~~~~~~~~~~~~~~~~~~
@@ -69,9 +72,11 @@ this value if you wrote your own implementation (subclass of
6972

7073
AUTHORIZATION_CODE_EXPIRE_SECONDS
7174
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
75+
Default: ``60``
76+
7277
The number of seconds an authorization code remains valid. Requesting an access
73-
token after this duration will fail. :rfc:`4.1.2` recommends a
74-
10 minutes (600 seconds) duration.
78+
token after this duration will fail. :rfc:`4.1.2` recommends expire after a short lifetime,
79+
with 10 minutes (600 seconds) being the maximum acceptable.
7580

7681
CLIENT_ID_GENERATOR_CLASS
7782
~~~~~~~~~~~~~~~~~~~~~~~~~

0 commit comments

Comments
 (0)