Splitted AuthorizedToken TestCase in two Test cases

Author: outsbart

oauth2_provider/tests/test_application_views.py

@@ -99,10 +99,3 @@ def test_application_detail_not_owner(self):
 
         response = self.client.get(reverse('oauth2_provider:detail', args=(self.app_bar_1.pk,)))
         self.assertEqual(response.status_code, 404)
-
-    def test_delete_view_deletes(self):
-        self.client.login(username="foo_user", password="123456")
-        response = self.client.post(reverse('oauth2_provider:delete', args=(self.app_foo_1.pk,)))
-
-        self.assertFalse(Application.objects.filter(pk=self.app_foo_1.pk).exists())
-        self.assertRedirects(response, reverse('oauth2_provider:list'))

oauth2_provider/tests/test_token_view.py

@@ -14,6 +14,9 @@
 
 
 class TestAuthorizedTokenViews(TestCase):
+    """
+    TestCase superclass for Authorized Token Views' Test Cases
+    """
     def setUp(self):
         self.foo_user = UserModel.objects.create_user("foo_user", "[email protected]", "123456")
         self.bar_user = UserModel.objects.create_user("bar_user", "[email protected]", "123456")
@@ -31,6 +34,11 @@ def tearDown(self):
         self.foo_user.delete()
         self.bar_user.delete()
 
+
+class TestAuthorizedTokenListView(TestAuthorizedTokenViews):
+    """
+    Tests for the Authorized Token ListView
+    """
     def test_list_view_authorization_required(self):
         """
         Test that the view redirects to login page if user is not logged-in.
@@ -97,6 +105,11 @@ def test_list_view_shows_correct_user_token(self):
         self.assertEqual(response.status_code, 200)
         self.assertIn(b'There are no authorized tokens yet.', response.content)
 
+
+class TestAuthorizedTokenDeleteView(TestAuthorizedTokenViews):
+    """
+    Tests for the Authorized Token DeleteView
+    """
     def test_delete_view_authorization_required(self):
         """
         Test that the view redirects to login page if user is not logged-in.

oauth2_provider/views/application.py

@@ -1,4 +1,4 @@
-from django.core.urlresolvers import reverse
+from django.core.urlresolvers import reverse_lazy
 from django.forms.models import modelform_factory
 from django.views.generic import CreateView, DetailView, DeleteView, ListView, UpdateView
 
@@ -59,11 +59,9 @@ class ApplicationDelete(ApplicationOwnerIsUserMixin, DeleteView):
     View used to delete an application owned by the request.user
     """
     context_object_name = 'application'
+    success_url = reverse_lazy('oauth2_provider:list')
     template_name = "oauth2_provider/application_confirm_delete.html"
 
-    def get_success_url(self):
-        return reverse('oauth2_provider:list')
-
 
 class ApplicationUpdate(ApplicationOwnerIsUserMixin, UpdateView):
     """

oauth2_provider/views/token.py

@@ -1,7 +1,8 @@
 from __future__ import absolute_import, unicode_literals
 
-from django.core.urlresolvers import reverse
+from django.core.urlresolvers import reverse_lazy
 from django.views.generic import ListView, DeleteView
+
 from braces.views import LoginRequiredMixin
 
 from ..models import AccessToken
@@ -28,10 +29,8 @@ class AuthorizedTokenDeleteView(LoginRequiredMixin, DeleteView):
     View for revoking a specific token
     """
     template_name = 'oauth2_provider/authorized-token-delete.html'
+    success_url = reverse_lazy('oauth2_provider:authorized-token-list')
     model = AccessToken
 
-    def get_success_url(self):
-        return reverse('oauth2_provider:authorized-token-list')
-
     def get_queryset(self):
         return super(AuthorizedTokenDeleteView, self).get_queryset().filter(user=self.request.user)