Skip to content

Commit 88d22e8

Browse files
smithdc1auvipy
authored andcommitted
Passing None into middleware is deprecated
1 parent 4a83d4c commit 88d22e8

File tree

2 files changed

+9
-5
lines changed

2 files changed

+9
-5
lines changed

AUTHORS

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,3 +30,4 @@ Rodney Richardson
3030
Silvano Cerza
3131
Stéphane Raimbault
3232
Jun Zhou
33+
David Smith

tests/test_auth_backends.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,11 @@ def setUp(self):
8888
super(TestOAuth2Middleware, self).setUp()
8989
self.anon_user = AnonymousUser()
9090

91+
def dummy_get_response(request):
92+
return None
93+
9194
def test_middleware_wrong_headers(self):
92-
m = OAuth2TokenMiddleware()
95+
m = OAuth2TokenMiddleware(self.dummy_get_response)
9396
request = self.factory.get("/a-resource")
9497
self.assertIsNone(m.process_request(request))
9598
auth_headers = {
@@ -99,7 +102,7 @@ def test_middleware_wrong_headers(self):
99102
self.assertIsNone(m.process_request(request))
100103

101104
def test_middleware_user_is_set(self):
102-
m = OAuth2TokenMiddleware()
105+
m = OAuth2TokenMiddleware(self.dummy_get_response)
103106
auth_headers = {
104107
"HTTP_AUTHORIZATION": "Bearer " + "tokstr",
105108
}
@@ -110,7 +113,7 @@ def test_middleware_user_is_set(self):
110113
self.assertIsNone(m.process_request(request))
111114

112115
def test_middleware_success(self):
113-
m = OAuth2TokenMiddleware()
116+
m = OAuth2TokenMiddleware(self.dummy_get_response)
114117
auth_headers = {
115118
"HTTP_AUTHORIZATION": "Bearer " + "tokstr",
116119
}
@@ -119,7 +122,7 @@ def test_middleware_success(self):
119122
self.assertEqual(request.user, self.user)
120123

121124
def test_middleware_response(self):
122-
m = OAuth2TokenMiddleware()
125+
m = OAuth2TokenMiddleware(self.dummy_get_response)
123126
auth_headers = {
124127
"HTTP_AUTHORIZATION": "Bearer " + "tokstr",
125128
}
@@ -129,7 +132,7 @@ def test_middleware_response(self):
129132
self.assertIs(response, processed)
130133

131134
def test_middleware_response_header(self):
132-
m = OAuth2TokenMiddleware()
135+
m = OAuth2TokenMiddleware(self.dummy_get_response)
133136
auth_headers = {
134137
"HTTP_AUTHORIZATION": "Bearer " + "tokstr",
135138
}

0 commit comments

Comments
 (0)