deal with 404 or 405 validator error (#1499)

* deal with 404 or 405 validator error (apparently varies with version of django)

* refactor: more precise test name

* mock the post request instead of POSTing to example.com

---------

Co-authored-by: Darrel O'Pry <[email protected]>

Author: n2ygk

tests/test_oauth2_validators.py

@@ -3,6 +3,7 @@
 import json
 
 import pytest
+import requests
 from django.contrib.auth import get_user_model
 from django.contrib.auth.hashers import make_password
 from django.utils import timezone
@@ -501,18 +502,26 @@ def setUpTestData(cls):
         cls.introspection_token = "test_introspection_token"
         cls.validator = OAuth2Validator()
 
-    def test_response_when_auth_server_response_return_404(self):
-        with self.assertLogs(logger="oauth2_provider") as mock_log:
-            self.validator._get_token_from_authentication_server(
-                self.token, self.introspection_url, self.introspection_token, None
-            )
-            self.assertIn(
-                "ERROR:oauth2_provider:Introspection: Failed to "
-                "get a valid response from authentication server. "
-                "Status code: 404, Reason: "
-                "Not Found.\nNoneType: None",
-                mock_log.output,
-            )
+    def test_response_when_auth_server_response_not_200(self):
+        """
+        Ensure we log the error when the authentication server returns a non-200 response.
+        """
+        mock_response = requests.Response()
+        mock_response.status_code = 404
+        mock_response.reason = "Not Found"
+        with mock.patch("requests.post") as mock_post:
+            mock_post.return_value = mock_response
+            with self.assertLogs(logger="oauth2_provider") as mock_log:
+                self.validator._get_token_from_authentication_server(
+                    self.token, self.introspection_url, self.introspection_token, None
+                )
+                self.assertIn(
+                    "ERROR:oauth2_provider:Introspection: Failed to "
+                    "get a valid response from authentication server. "
+                    "Status code: 404, Reason: "
+                    "Not Found.\nNoneType: None",
+                    mock_log.output,
+                )
 
 
 @pytest.mark.oauth2_settings(presets.OIDC_SETTINGS_RW)