Add assertion to ensure that request has a client attr on _load_application

Author: synasius

oauth2_provider/oauth2_validators.py

@@ -94,6 +94,10 @@ def _load_application(self, client_id, request):
         If request.client was not set, load application instance for given client_id and store it
         in request.client
         """
+
+        # we want to be sure that request has the client attribute!
+        assert hasattr(request, "client"), "'request' instance has no 'client' attribute"
+
         try:
             request.client = request.client or Application.objects.get(client_id=client_id)
             return request.client

oauth2_provider/tests/test_oauth2_validators.py

@@ -65,3 +65,6 @@ def test_client_authentication_required(self):
         self.application.save()
         self.request.client = ''
         self.assertTrue(self.validator.client_authentication_required(self.request))
+
+    def test_load_application_fails_when_request_has_no_client(self):
+        self.assertRaises(AssertionError, self.validator.authenticate_client_id, 'client_id', {})