runserver: skip ASGI_APPLICATION check with --noasgi (#1289)

blueyed · carltongibson · commit 17f8a039bc1c · 2019-05-06T16:13:09.000+02:00
diff --git a/channels/management/commands/runserver.py b/channels/management/commands/runserver.py
@@ -51,7 +51,7 @@ def handle(self, *args, **options):
         self.http_timeout = options.get("http_timeout", None)
         self.websocket_handshake_timeout = options.get("websocket_handshake_timeout", 5)
         # Check Channels is installed right
-        if not hasattr(settings, "ASGI_APPLICATION"):
+        if options["use_asgi"] and not hasattr(settings, "ASGI_APPLICATION"):
             raise CommandError(
                 "You have not set ASGI_APPLICATION, which is needed to run the server."
             )

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def handle(self, args, *options):`
`51`	`51`	`self.http_timeout = options.get("http_timeout", None)`
`52`	`52`	`self.websocket_handshake_timeout = options.get("websocket_handshake_timeout", 5)`
`53`	`53`	`# Check Channels is installed right`
`54`		`- if not hasattr(settings, "ASGI_APPLICATION"):`
	`54`	`+ if options["use_asgi"] and not hasattr(settings, "ASGI_APPLICATION"):`
`55`	`55`	`raise CommandError(`
`56`	`56`	`"You have not set ASGI_APPLICATION, which is needed to run the server."`
`57`	`57`	`)`