Skip to content

Commit 11e0574

Browse files
committed
Fix a few query benchmarks for deprecations in Django
1 parent 2508845 commit 11e0574

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

djangobench/benchmarks/query_delete_related/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,5 +5,5 @@ class Book(models.Model):
55
title = models.CharField(max_length=100)
66

77
class Chapter(models.Model):
8-
book = models.ForeignKey(Book)
8+
book = models.ForeignKey(Book, on_delete=models.CASCADE)
99
title = models.CharField(max_length=100)

djangobench/benchmarks/query_prefetch_related/benchmark.py

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,8 @@ def setup():
1515
from query_prefetch_related.models import Book, Author
1616
for i in range(0, 20):
1717
a = Author.objects.create(author="Author %s" % i)
18-
bset = set()
19-
for j in range(0, 3):
20-
b = Book.objects.create(title="Title %s" % j)
21-
bset.add(b)
22-
a.books = bset
18+
books = [Book.objects.create(title="Title %s" % j) for j in range(0, 3)]
19+
a.books.add(*books)
2320

2421
if VERSION < (1, 4):
2522
print("SKIP: prefetch_related not supported before Django 1.4")

djangobench/benchmarks/query_select_related/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
class Book(models.Model):
55
title = models.CharField(max_length=100)
6-
author = models.ForeignKey('Author')
6+
author = models.ForeignKey('Author', on_delete=models.CASCADE)
77

88
class Author(models.Model):
99
author = models.CharField(max_length=100)

0 commit comments

Comments
 (0)