Fixed #1574 -- Added support for Python 3.12 (#1640)

Author: tobiasmcnulty

.github/workflows/tests.yml

@@ -12,6 +12,10 @@ jobs:
         runs-on: ubuntu-24.04
         strategy:
             fail-fast: false
+            matrix:
+                # tox-gh-actions will only run the tox environments which match the currently
+                # running python-version. See [gh-actions] in tox.ini for the mapping.
+                python-version: ["3.8", "3.12"]
 
         services:
             postgres:
@@ -27,14 +31,14 @@ jobs:
                     - 5432:5432
 
         steps:
-            - uses: actions/checkout@v2
+            - uses: actions/checkout@v4
             - name: Set up Python
               uses: actions/setup-python@v5
               with:
-                  python-version: "3.8"
+                  python-version: "${{ matrix.python-version }}"
             - name: Install dependencies
               run: |
-                  python -m pip install --upgrade pip setuptools coveralls "tox<5"
+                  python -m pip install --upgrade pip setuptools coveralls "tox<5" "tox-gh-actions<4"
             - name: Set up databases
               run: |
                   PGPASSWORD="postgres" createuser -U postgres -d djangoproject --superuser -h localhost

.pre-commit-config.yaml

@@ -19,6 +19,8 @@ repos:
       rev: "v3.17.0"
       hooks:
           - id: pyupgrade
+            # TODO: Update to --py312 when dropping support for
+            # Python 3.8
             args: [--py38-plus]
     - repo: https://github.com/adamchainz/django-upgrade
       rev: "1.21.0"

Dockerfile

@@ -1,5 +1,5 @@
 # pull official base image
-FROM python:3.8-slim-bullseye
+FROM python:3.12-slim-bookworm
 
 # set work directory
 WORKDIR /usr/src/app
@@ -17,7 +17,7 @@ RUN apt-get update \
         make \
         netcat-openbsd \
         npm \
-        postgresql-client-13 \
+        postgresql-client-15 \
         rsync \
         zlib1g \
     && rm -rf /var/lib/apt/lists/*

README.rst

@@ -15,7 +15,7 @@ To run locally, you can either:
 Install and run locally from a virtual environment
 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 
-#. Create a `Python 3.8+ virtualenv and activate it <https://docs.python.org/3/library/venv.html>`_
+#. Create a `Python Python 3.8 or 3.12 virtualenv and activate it <https://docs.python.org/3/library/venv.html>`_
 
 #. Install dependencies::
 

requirements/common.txt

@@ -19,4 +19,4 @@ pykismet3==0.1.1
 requests==2.32.3
 sorl-thumbnail==12.10.0
 Sphinx==4.5.0
-stripe==2.56.0
+stripe==3.1.0

tox.ini

@@ -1,7 +1,12 @@
 [tox]
-envlist =py38-{tests,flake8,black,isort}
+envlist =py{38,312}-{tests,flake8,black,isort}
 skipsdist = true
 
+[gh-actions]
+python =
+    3.8: py38
+    3.12: py312
+
 [testenv]
 allowlist_externals = make
 passenv = DJANGO_SETTINGS_MODULE

tracdb/models.py

@@ -50,7 +50,11 @@
 
 from django.db import models
 
-_epoc = datetime.datetime(1970, 1, 1, tzinfo=datetime.timezone.utc)
+try:
+    _epoc = datetime.datetime(1970, 1, 1, tzinfo=datetime.UTC)
+except AttributeError:
+    # TODO: Remove when dropping support for Python 3.8
+    _epoc = datetime.datetime(1970, 1, 1, tzinfo=datetime.timezone.utc)
 
 
 class time_property:

tracdb/views.py

@@ -3,6 +3,8 @@
 from django import db
 from django.shortcuts import render
 
+from .models import _epoc
+
 
 def bouncing_tickets(request):
     c = db.connections["trac"].cursor()
@@ -27,8 +29,7 @@ def bouncing_tickets(request):
 
 
 def ts2dt(ts):
-    epoc = datetime.datetime(1970, 1, 1, tzinfo=datetime.timezone.utc)
-    return epoc + datetime.timedelta(microseconds=ts)
+    return _epoc + datetime.timedelta(microseconds=ts)
 
 
 def dictfetchall(cursor):