Replace magic string weblog with constant.

Author: tim-schilling

docs/models.py

@@ -34,6 +34,7 @@
     START_SEL,
     STOP_SEL,
     TSEARCH_CONFIG_LANGUAGES,
+    DocumentationCategory,
 )
 
 
@@ -237,9 +238,12 @@ def _sync_blog_to_db(self):
                     metadata={
                         "body": entry.body_html,
                         "breadcrumbs": [
-                            {"path": "weblog", "title": "News"},
+                            {
+                                "path": DocumentationCategory.WEBSITE.value,
+                                "title": "News",
+                            },
                         ],
-                        "parents": "weblog",
+                        "parents": DocumentationCategory.WEBSITE.value,
                         "slug": entry.slug,
                         "title": entry.headline,
                         "toc": "",
@@ -279,9 +283,12 @@ def _sync_views_to_db(self):
                     metadata={
                         "body": body,
                         "breadcrumbs": [
-                            {"path": "weblog", "title": "Website"},
+                            {
+                                "path": DocumentationCategory.WEBSITE.value,
+                                "title": "Website",
+                            },
                         ],
-                        "parents": "weblog",
+                        "parents": DocumentationCategory.WEBSITE.value,
                         "slug": url_name,
                         "title": title,
                         "toc": "",
@@ -303,7 +310,7 @@ def _clean_document_path(path):
 
 
 def document_url(doc):
-    if doc.metadata["parents"] == "weblog":
+    if doc.metadata["parents"] == DocumentationCategory.WEBSITE.value:
         return doc.path
     elif doc.path:
         kwargs = {

docs/tests/test_models.py

@@ -11,6 +11,7 @@
 from releases.models import Release
 
 from ..models import DOCUMENT_SEARCH_VECTOR, Document, DocumentRelease
+from ..search import DocumentationCategory
 
 
 class ModelsTests(TestCase):
@@ -480,7 +481,9 @@ def setUpTestData(cls):
             slug="a",
             body_html="<h1>Searchable Blog Post</h1>",
         )
-        cls.docs_documents = cls.release.documents.exclude(metadata__parents="weblog")
+        cls.docs_documents = cls.release.documents.exclude(
+            metadata__parents=DocumentationCategory.WEBSITE.value
+        )
 
     def test_sync_to_db(self):
         self.release.sync_to_db(