Simplified cache usage in accounts view helper (#2089)

Importing `cache` instead of `caches` uses the default cache.

Author: adamzap

accounts/tests.py

@@ -1,4 +1,7 @@
+import hashlib
+
 from django.contrib.auth.models import User
+from django.core.cache import cache
 from django.test import TestCase, override_settings
 from django_hosts.resolvers import reverse
 
@@ -152,6 +155,23 @@ def test_stat_tickets_triaged_unaccepted_not_counted(self):
         response = self.client.get(self.user1_url)
         self.assertContains(response, "New tickets triaged: 1.")
 
+    @override_settings(
+        CACHES={
+            "default": {
+                "BACKEND": "django.core.cache.backends.locmem.LocMemCache",
+                "LOCATION": "unique-snowflake",
+            }
+        }
+    )
+    def test_caches_trac_stats(self):
+        key = "user_vital_status:%s" % hashlib.md5(b"user1").hexdigest()
+
+        self.assertIsNone(cache.get(key))
+
+        self.client.get(self.user1_url)
+
+        self.assertIsNotNone(cache.get(key))
+
 
 class ViewsTests(TestCase):
 

accounts/views.py

@@ -2,7 +2,7 @@
 
 from django.contrib.auth.decorators import login_required
 from django.contrib.auth.models import User
-from django.core.cache import caches
+from django.core.cache import cache
 from django.shortcuts import get_object_or_404, redirect, render
 
 from tracdb import stats as trac_stats
@@ -35,16 +35,15 @@ def edit_profile(request):
 
 
 def get_user_stats(user):
-    c = caches["default"]
     username = user.username.encode("ascii", "ignore")
     key = "user_vital_status:%s" % hashlib.md5(username).hexdigest()
-    info = c.get(key)
+    info = cache.get(key)
     if info is None:
         info = trac_stats.get_user_stats(user.username)
         # Hide any stat with a value = 0 so that we don't accidentally insult
         # non-contributors.
         for k, v in list(info.items()):
             if v.count == 0:
                 info.pop(k)
-        c.set(key, info, 60 * 60)
+        cache.set(key, info, 60 * 60)
     return info