Skip to content

Commit 5d20339

Browse files
committed
Use labels instead of placeholders on contact form
1 parent 01fa337 commit 5d20339

File tree

2 files changed

+11
-8
lines changed

2 files changed

+11
-8
lines changed

contact/forms.py

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,20 @@
1717
class BaseContactForm(ContactForm):
1818
message_subject = forms.CharField(
1919
max_length=100,
20-
widget=forms.TextInput(
21-
attrs={"class": "required", "placeholder": _("Message subject")}
22-
),
20+
widget=forms.TextInput(attrs={"class": "required"}),
2321
label=_("Message subject"),
2422
)
2523
email = forms.EmailField(
26-
widget=forms.TextInput(attrs={"class": "required", "placeholder": _("E-mail")})
24+
widget=forms.TextInput(attrs={"class": "required"}),
25+
label=_("E-mail"),
2726
)
2827
name = forms.CharField(
29-
widget=forms.TextInput(attrs={"class": "required", "placeholder": _("Name")})
28+
widget=forms.TextInput(attrs={"class": "required"}),
29+
label=_("Name"),
3030
)
3131
body = forms.CharField(
32-
widget=forms.Textarea(
33-
attrs={"class": "required", "placeholder": _("Your message")}
34-
)
32+
widget=forms.Textarea(attrs={"class": "required"}),
33+
label=_("Your message"),
3534
)
3635
captcha = ReCaptchaField(widget=ReCaptchaV3)
3736

djangoproject/templates/contact/foundation.html

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,18 +32,22 @@ <h1>{% translate "Contact the Django Software Foundation" %}</h1>
3232
<form action="." method="post" accept-charset="utf-8" class="form-input">
3333
{% csrf_token %}
3434
<p>
35+
<label for="{{ form.name.id_for_label }}">{{ form.name.label }}</label>
3536
{% if form.name.errors %}<p class="errors">{{ form.name.errors.as_text }}</p>{% endif %}
3637
{{ form.name }}
3738
</p>
3839
<p class="form-email">
40+
<label for="{{ form.email.id_for_label }}">{{ form.email.label }}</label>
3941
{% if form.email.errors %}<p class="errors">{{ form.email.errors.as_text }}</p>{% endif %}
4042
{{ form.email }}
4143
</p>
4244
<p>
45+
<label for="{{ form.message_subject.id_for_label }}">{{ form.message_subject.label }}</label>
4346
{% if form.message_subject.errors %}<p class="errors">{{ form.message_subject.errors.as_text }}</p>{% endif %}
4447
{{ form.message_subject }}
4548
</p>
4649
<p>
50+
<label for="{{ form.body.id_for_label }}">{{ form.body.label }}</label>
4751
{% if form.body.errors %}<p class="errors">{{ form.body.errors.as_text }}</p>{% endif %}
4852
{{ form.body }}
4953
</p>

0 commit comments

Comments
 (0)