Skip to content

Conversation

bishnusyangja
Copy link

No description provided.

@bishnusyangja
Copy link
Author

bishnusyangja commented Jul 9, 2025

Hi Could you please anyone have any comment on this PR ? I though I have fixed the issue and is ready for review and merge.

@WajahatKanju
Copy link
Contributor

good job

@bishnusyangja
Copy link
Author

Hi, is this PR okay to merge ? If I need to workout anything more to make it ready for merge, let me know.

@ulgens ulgens requested a review from a team August 18, 2025 14:52
Copy link
Contributor

@SaptakS SaptakS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me. I added a comment about showing the GitHub repo link as a link in the page.

@@ -11,11 +11,13 @@
{% block content %}
<h1>{% translate "Meeting minutes archive" %}</h1>

<p>{% translate "Select a year to view meeting minutes:" %}</p>
<p>{% translate "The minutes from May 2025 onwards are stored in the repo https://github.com/django/dsf-minutes" %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SaptakS I have updated the PR with the changes you have requested, I hope this will address your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants