Skip to content

Commit 397ac26

Browse files
authored
Fixed pagination component accessibility. (#542)
1 parent 822c1ff commit 397ac26

File tree

2 files changed

+9
-13
lines changed

2 files changed

+9
-13
lines changed

djangosnippets/static/scss/main.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,6 @@ nav.pagination {
367367
margin-left: 1rem;
368368
margin-right: 1rem;
369369
}
370-
371370
li {
372371
display: inline-block;
373372
a, em, span {
@@ -397,7 +396,6 @@ nav.pagination {
397396
border-color: transparent;
398397
}
399398
}
400-
401399
.previous-page::before, .next-page::after {
402400
display: inline-block;
403401
width: 1rem;
@@ -406,12 +404,10 @@ nav.pagination {
406404
content: "";
407405
background-color: currentColor;
408406
}
409-
410407
.previous-page::before {
411408
clip-path: polygon(9.8px 12.8px, 8.7px 12.8px, 4.5px 8.5px, 4.5px 7.5px, 8.7px 3.2px, 9.8px 4.3px, 6.1px 8px, 9.8px 11.7px, 9.8px 12.8px);
412409
margin-right: 4px;
413410
}
414-
415411
.next-page::after {
416412
clip-path: polygon(6.2px 3.2px, 7.3px 3.2px, 11.5px 7.5px, 11.5px 8.5px, 7.3px 12.8px, 6.2px 11.7px, 9.9px 8px, 6.2px 4.3px, 6.2px 3.2px);
417413
margin-left: 4px;
Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,21 @@
11
{% load components %}
22

33
{% if pagination.multi_page %}
4-
<nav class="pagination" aria-labelledby="pagination">
5-
{% if pagination.page.has_previous %}
4+
<nav class="pagination" aria-label="pagination">
5+
<ul>
6+
<li>{% if pagination.page.has_previous %}
67
<a class="previous-page" href="{{ previous_page_link }}" rel="prev" aria-label="Previous page">Previous</a>
78
{% else %}
8-
<span class="previous-page disabled" rel="prev" aria-label="Previous page">Previous</span>
9-
{% endif %}
10-
<ul>
9+
<span class="previous-page disabled">Previous</span>
10+
{% endif %}</li>
1111
{% for i in pagination.page_range %}
1212
<li>{% pagination_number pagination i %}</li>
1313
{% endfor %}
14-
</ul>
15-
{% if pagination.page.has_next %}
14+
<li>{% if pagination.page.has_next %}
1615
<a class="next-page" href="{{ next_page_link }}" rel="next" aria-label="Next page">Next</a>
1716
{% else %}
18-
<span class="next-page disabled" rel="next" aria-label="Next page">Next</span>
19-
{% endif %}
17+
<span class="next-page disabled">Next</span>
18+
{% endif %}</li>
19+
</ul>
2020
</nav>
2121
{% endif %}

0 commit comments

Comments
 (0)