fix: send_device_attestation breaks CBOR encoding of attestation object

Author: christianhoelzl

src/order.rs

@@ -475,8 +475,14 @@ impl ChallengeHandle<'_> {
             return Err(Error::Str("challenge type should be device-attest-01"));
         }
 
-        let payload = DeviceAttestation {
-            att_obj: Cow::Owned(BASE64_URL_SAFE_NO_PAD.encode(&payload.att_obj).into()),
+        #[derive(Serialize)]
+        #[serde(rename_all = "camelCase")]
+        struct DeviceAttestationBase64<'a> {
+            att_obj: Cow<'a, str>,
+        }
+
+        let payload = DeviceAttestationBase64 {
+            att_obj: Cow::Owned(BASE64_URL_SAFE_NO_PAD.encode(&payload.att_obj)),
         };
 
         let rsp = self

src/types.rs

@@ -958,10 +958,8 @@ pub(crate) enum SigningAlgorithm {
 /// Attestation payload used for device-attest-01
 ///
 /// See <https://datatracker.ietf.org/doc/draft-acme-device-attest/> for details.
-#[derive(Serialize)]
-#[serde(rename_all = "camelCase")]
 pub struct DeviceAttestation<'a> {
-    /// attestation payload
+    /// CBOR encoded attestation payload
     pub att_obj: Cow<'a, [u8]>,
 }