fix: send_device_attestation yields challenge status

Author: christianhoelzl

src/order.rs

@@ -15,7 +15,7 @@ use crate::types::{
     Authorization, AuthorizationState, AuthorizationStatus, AuthorizedIdentifier, Challenge,
     ChallengeType, DeviceAttestation, Empty, FinalizeRequest, OrderState, OrderStatus, Problem,
 };
-use crate::{Error, Key, crypto, nonce_from_response, retry_after};
+use crate::{ChallengeStatus, Error, Key, crypto, nonce_from_response, retry_after};
 
 /// An ACME order as described in RFC 8555 (section 7.1.3)
 ///
@@ -462,10 +462,13 @@ impl ChallengeHandle<'_> {
     /// `payload` is the device attestation object as defined in link. Provide the attestation
     /// object as a raw blob. Base64 encoding of the attestation object `payload.att_obj`
     /// is done by this function.
+    ///
+    /// The function yields the challenge status from the ACME server that validated the
+    /// attestation challenge.
     pub async fn send_device_attestation(
         &mut self,
         payload: &DeviceAttestation<'_>,
-    ) -> Result<(), Error> {
+    ) -> Result<ChallengeStatus, Error> {
         if self.challenge.r#type != ChallengeType::DeviceAttest01 {
             return Err(Error::Str("challenge type should be device-attest-01"));
         }
@@ -483,7 +486,7 @@ impl ChallengeHandle<'_> {
         let response = Problem::check::<Challenge>(rsp).await?;
         match response.error {
             Some(details) => Err(Error::Api(details)),
-            None => Ok(()),
+            None => Ok(response.status),
         }
     }
 

src/types.rs

@@ -730,6 +730,7 @@ pub enum ChallengeType {
     Unknown(String),
 }
 
+/// Status of an ACME [Challenge]
 #[allow(missing_docs)]
 #[derive(Clone, Copy, Debug, Deserialize, Eq, PartialEq)]
 #[serde(rename_all = "camelCase")]