-
-
Notifications
You must be signed in to change notification settings - Fork 30
Description
Our Rust API is currently completely abstract over types that implement the Point
trait:
pub trait Point: Clone + Sync {
fn distance(&self, other: &Self) -> f32;
}
An important part of making instant-distance fast is making the distance()
implementation fast, which comes down to using a SIMD implementation. I wrote such an implementation which is specialized for the case of [f32; 300]
because that's what we typically use for InstantDomainSearch (since Meta's FastText vectors have 300 elements).
However, for the Python bindings, we have some other needs. There, we don't really have the opportunity to make use of compile-time generics; the vector length should be run-time property of the vector. Since we probably don't want to dereference through a pointer for every vector element access, this also means we might want to change the Hnsw
implementations to hold a Vec<f32>
instead of a Vec<[f32; 300]>
(for example), without losing the performance benefits of avoiding bounds checking where possible. For the Python API, we should then also do a SIMD distance implementation that can adjust to the size of the vector at run-time, ideally without much performance loss compared to the current, fixed-length implementation.