ipfs: all - normalize op strings

The Go standard library seems to use a normalized name format of
lowercase, non-annotated operation names. We'll mimic this, especially
since type names could change and break these prefixes (as can be seen
in `pinDirectory.Close`).

Author: djdv

internal/filesystem/ipfs/ipfs.go

@@ -168,7 +168,7 @@ func (fsys *IPFS) Close() error {
 }
 
 func (fsys *IPFS) Stat(name string) (fs.FileInfo, error) {
-	const op = "IPFS.Stat"
+	const op = "stat"
 	if name == filesystem.Root {
 		return &fsys.info, nil
 	}
@@ -463,12 +463,12 @@ func (fsys *IPFS) openFile(cid cid.Cid, info *nodeInfo) (fs.File, error) {
 func (id *ipfsDirectory) Stat() (fs.FileInfo, error) { return id.info, nil }
 
 func (id *ipfsDirectory) Read([]byte) (int, error) {
-	const op = "ipfsDirectory.Read"
+	const op = "read"
 	return -1, fserrors.New(op, id.info.name, filesystem.ErrIsDir, fserrors.IsDir)
 }
 
 func (id *ipfsDirectory) StreamDir() <-chan filesystem.StreamDirEntry {
-	const op = "ipfsDirectory.StreamDir"
+	const op = "streamdir"
 	stream := id.stream
 	if stream == nil {
 		errs := make(chan filesystem.StreamDirEntry, 1)
@@ -483,7 +483,7 @@ func (id *ipfsDirectory) StreamDir() <-chan filesystem.StreamDirEntry {
 }
 
 func (id *ipfsDirectory) ReadDir(count int) ([]fs.DirEntry, error) {
-	const op = "ipfsDirectory.ReadDir"
+	const op = "readdir"
 	if err := id.err; err != nil {
 		return nil, err
 	}
@@ -506,7 +506,7 @@ func (id *ipfsDirectory) ReadDir(count int) ([]fs.DirEntry, error) {
 }
 
 func (id *ipfsDirectory) Close() error {
-	const op = "ipfsDirectory.Close"
+	const op = "close"
 	if stream := id.stream; stream != nil {
 		stream.CancelFunc()
 		id.stream = nil

internal/filesystem/ipfs/keyfs.go

@@ -172,7 +172,7 @@ func (kfs *KeyFS) openRoot() (fs.ReadDirFile, error) {
 }
 
 func (*keyDirectory) Read([]byte) (int, error) {
-	const op = "keyDirectory.Read"
+	const op = "read"
 	return -1, fserrors.New(op, filesystem.Root, filesystem.ErrIsDir, fserrors.IsDir)
 }
 
@@ -186,7 +186,7 @@ func (kd *keyDirectory) IsDir() bool        { return kd.Mode().IsDir() }
 func (kd *keyDirectory) Sys() any           { return kd }
 
 func (kd *keyDirectory) ReadDir(count int) ([]fs.DirEntry, error) {
-	const op = "keyDirectory.ReadDir"
+	const op = "readdir"
 	if err := kd.err; err != nil {
 		return nil, err
 	}
@@ -210,7 +210,7 @@ func (kd *keyDirectory) ReadDir(count int) ([]fs.DirEntry, error) {
 }
 
 func (kd *keyDirectory) Close() error {
-	const op = "keyDirectory.Close"
+	const op = "close"
 	if stream := kd.stream; stream != nil {
 		stream.CancelFunc()
 		kd.stream = nil

internal/filesystem/ipfs/pinfs.go

@@ -272,12 +272,12 @@ func (pi *pinDirectoryInfo) Sys() any           { return pi }
 
 func (pd *pinDirectory) Stat() (fs.FileInfo, error) { return &pd.info, nil }
 func (*pinDirectory) Read([]byte) (int, error) {
-	const op = "pinDirectory.Read"
+	const op = "read"
 	return -1, fserrors.New(op, filesystem.Root, filesystem.ErrIsDir, fserrors.IsDir)
 }
 
 func (pd *pinDirectory) ReadDir(count int) ([]fs.DirEntry, error) {
-	const op = "pinDirectory.ReadDir"
+	const op = "readdir"
 	if err := pd.err; err != nil {
 		return nil, err
 	}
@@ -300,7 +300,7 @@ func (pd *pinDirectory) ReadDir(count int) ([]fs.DirEntry, error) {
 }
 
 func (pd *pinDirectory) StreamDir() <-chan filesystem.StreamDirEntry {
-	const op = "pinDirectory.StreamDir"
+	const op = "streamdir"
 	stream := pd.stream
 	if stream == nil {
 		errs := make(chan filesystem.StreamDirEntry, 1)
@@ -315,7 +315,7 @@ func (pd *pinDirectory) StreamDir() <-chan filesystem.StreamDirEntry {
 }
 
 func (pd *pinDirectory) Close() error {
-	const op = "pinStream.Close"
+	const op = "close"
 	if stream := pd.stream; stream != nil {
 		stream.CancelFunc()
 		pd.stream = nil