-
Notifications
You must be signed in to change notification settings - Fork 65
Description
With the latest changes to bootstrapping the page with data instead of bundling the people data with the javascript, React show a warning in the console:
React attempted to use reuse markup in a container but the checksum was invalid. This generally means that you are using server rendering and the markup generated on the server was not what the client was expecting. React injected new markup to compensate which works but you have lost many of the benefits of server rendering. Instead, figure out why the markup being generated is different on the client or server.
We're losing a big benefit of server-client rendering that React can provide, so it's ideal to fix this! The checksums do not match since the time will never match exactly when the page is re-rendered. I think the bootstrapped data shouldn't contain the time param and all timezone math logic should be removed from the views themselves. This will also help the app follow a more Flux pattern, making the views simpler!