Merge pull request ClickHouse#93016 from Avogar/fix-sparse-mutation

Fix possible error FILE_DOESNT_EXIST after sparse column mutation

Author: Avogar

src/Storages/MergeTree/MutateTask.cpp

@@ -443,12 +443,20 @@ static void splitAndModifyMutationCommands(
                 || command.type == MutationCommand::Type::MATERIALIZE_TTL
                 || command.type == MutationCommand::Type::REWRITE_PARTS
                 || command.type == MutationCommand::Type::DELETE
-                || command.type == MutationCommand::Type::UPDATE
                 || command.type == MutationCommand::Type::APPLY_DELETED_MASK
                 || command.type == MutationCommand::Type::APPLY_PATCHES)
             {
                 for_interpreter.push_back(command);
             }
+            else if (command.type == MutationCommand::Type::UPDATE)
+            {
+                for_interpreter.push_back(command);
+
+                /// Update column can change the set of substreams for column if it
+                /// changes serialization (for example from Sparse to not Sparse).
+                /// We add it "for renames" because these set of commands also removes redundant files
+                for_file_renames.push_back(command);
+            }
             else if (command.type == MutationCommand::Type::DROP_INDEX
                      || command.type == MutationCommand::Type::DROP_PROJECTION
                      || command.type == MutationCommand::Type::DROP_STATISTICS)
@@ -1060,7 +1068,7 @@ static NameToNameVector collectFilesForRenames(
                     add_rename(*filename, new_filename);
                 }
             }
-            else if (command.type == MutationCommand::Type::READ_COLUMN || command.type == MutationCommand::Type::MATERIALIZE_COLUMN)
+            else if (command.type == MutationCommand::Type::UPDATE || command.type == MutationCommand::Type::READ_COLUMN || command.type == MutationCommand::Type::MATERIALIZE_COLUMN)
             {
                 /// Remove files for streams that exist in source_part,
                 /// but were removed in new_part by MODIFY COLUMN or MATERIALIZE COLUMN from

tests/queries/0_stateless/03778_mutation_bad_sparse_cration_with_altered_ration.reference

@@ -0,0 +1,10 @@
+0	0
+1	0
+2	0
+3	0
+4	0
+5	0
+6	0
+7	0
+8	0
+9	0

tests/queries/0_stateless/03778_mutation_bad_sparse_cration_with_altered_ration.sql

@@ -0,0 +1,9 @@
+drop table if exists test;
+create table test (a UInt32, b UInt32) engine=MergeTree order by tuple() settings min_bytes_for_wide_part=0, ratio_of_defaults_for_sparse_serialization=0.0, max_suspicious_broken_parts=0, max_suspicious_broken_parts_bytes=0;
+insert into test select number, number from numbers(10);
+alter table test modify setting ratio_of_defaults_for_sparse_serialization=1.0;
+alter table test update b = 0 where 1 settings mutations_sync=2;
+detach table test;
+attach table test;
+select * from test;
+