when stat fails, server should return 404 (#95)

dkhalife · web-flow · commit b465eb5bf5ff · 2025-03-18T20:07:16.000-07:00
diff --git a/frontend/handler.go b/frontend/handler.go
@@ -35,13 +35,14 @@ func staticMiddleware(root string) gin.HandlerFunc {
 	return func(c *gin.Context) {
 		_, err := fs.Stat(embeddedFiles, "dist"+c.Request.URL.Path)
 		if err != nil {
-			c.Next()
+			c.AbortWithStatus(http.StatusNotFound)
 			return
 		}
-		fileServer.ServeHTTP(c.Writer, c.Request)
 
+		fileServer.ServeHTTP(c.Writer, c.Request)
 	}
 }
+
 func staticMiddlewareNoRoute(root string) gin.HandlerFunc {
 	fileServer := http.FileServer(getFileSystem(root))
 

Original file line number	Diff line number	Diff line change
`@@ -35,13 +35,14 @@ func staticMiddleware(root string) gin.HandlerFunc {`
`35`	`35`	`return func(c *gin.Context) {`
`36`	`36`	`_, err := fs.Stat(embeddedFiles, "dist"+c.Request.URL.Path)`
`37`	`37`	`if err != nil {`
`38`		`- c.Next()`
	`38`	`+ c.AbortWithStatus(http.StatusNotFound)`
`39`	`39`	`return`
`40`	`40`	`}`
`41`		`- fileServer.ServeHTTP(c.Writer, c.Request)`
`42`	`41`
	`42`	`+ fileServer.ServeHTTP(c.Writer, c.Request)`
`43`	`43`	`}`
`44`	`44`	`}`
	`45`	`+`
`45`	`46`	`func staticMiddlewareNoRoute(root string) gin.HandlerFunc {`
`46`	`47`	`fileServer := http.FileServer(getFileSystem(root))`
`47`	`48`