Update go.mod to 1.25 to support new language

[element-of-surprise]

Error when running the tool:

Problem:

/var/folders/rd/hbhb8s197633_f8ncy6fmpqr0000gn/T/goptimizer/1cc734a3-9777-482e-8c1d-c3f85d6779c0/service/service.go:3:1: package requires newer Go version go1.25 (application built with go1.24)
-: This application uses version go1.24 of the source-processing packages but runs version go1.25 of 'go list'. It may fail to process source files that rely on newer language features. If so, rebuild the application using a newer version of Go.

Fix:
Cloned the repo, set go.mod file to have: go 1.25.0 and did a new "go install" which then allowed betteralign to work.

[dkorunic]

Betteralign should work without any issues on Go 1.24 and Go 1.25 projects. Can you elaborate more on your project environment that you've observed the issue with, to be more precise go.mod "go" and "toolchain" directives?

[johnsiilver]

So the module directive was:
go 1.25.0

No toolchain directive.

That error I found seems to be an error from the x tools:
https://go.googlesource.com/tools/+/HEAD/go/packages/packages.go#1154

This seems to say if the version of the tool it is built on is < that the package version, it will fail because it can't guarantee it understands the format.

[johnsiilver]

Also, I seem to have found some cases where it makes a change to files via apply, but it gives an exit code of 3. I did not see that in the source code directly. Everything works, it just gives a non-zero error code.

[dkorunic]

Also, I seem to have found some cases where it makes a change to files via apply, but it gives an exit code of 3. I did not see that in the source code directly. Everything works, it just gives a non-zero error code.

This is unrelated but expected, this is how analysis.Analyzer packages work when there is more work to perform, as they are not designed to be single-pass only. Sadly there is nothing I can do about it, as the underlying analysis package is from Golang team.

[dkorunic]

So the module directive was: go 1.25.0
[...]
This seems to say if the version of the tool it is built on is < that the package version, it will fail because it can't guarantee it understands the format.

Simple go install github.com/dkorunic/betteralign/cmd/betteralign@latest from your environment should get and compile betteralign against Go runtime of your choice, in this particular example 1.25.x and it should continue working with any Go 1.25 code. I am positive that this is exactly how it works as I'm working on all my other Go 1.25 projects w/o any issues.

[johnsiilver]

Roger on the analysis.Analyzer. I've been wrapping the binary so I could modify all files for a binary at compile time, couldn't figure out how to call it directly in a way that worked, but the exit 3 code caught me off guard.

Simple go install github.com/dkorunic/betteralign/cmd/betteralign@latest from your environment should get and compile betteralign against Go runtime of your choice, in this particular example 1.25.x and it should continue working with any Go 1.25 code. I am positive that this is exactly how it works as I'm working on all my other Go 1.25 projects w/o any issues.

That didn't seem to work, but it's possible my environment was dirty in some way and I'm conflating my fix with something else that got changed. Feel free to close the issue.

And wanted to thank you for both the response and for even doing the project. Open source is rarely rewarded and I want to thank you for your work.