Skip to content

Commit 420be74

Browse files
authored
Data integrity: bump to cz 0.16.1, adjust sync mode. (apple#939)
- 0.16.1 changes an ext4 superblock setting that might have been causing problems. - apple#877 fixed an issue where the cache and sync settings for block filesystems weren't being passed down to the VZ virtual machine configuration. The default sync value getting passed down is `full`, which reduces I/O performance. Relax this to use `fsync` for now. ## Type of Change - [*] Bug fix - [ ] New feature - [ ] Breaking change - [ ] Documentation update ## Motivation and Context May address problems reported in apple#877. ## Testing - [x] Tested locally - [ ] Added/updated tests - [ ] Added/updated docs
1 parent f7bcb68 commit 420be74

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

Package.resolved

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ import PackageDescription
2323
let releaseVersion = ProcessInfo.processInfo.environment["RELEASE_VERSION"] ?? "0.0.0"
2424
let gitCommit = ProcessInfo.processInfo.environment["GIT_COMMIT"] ?? "unspecified"
2525
let builderShimVersion = "0.7.0"
26-
let scVersion = "0.16.0"
26+
let scVersion = "0.16.1"
2727

2828
let package = Package(
2929
name: "container",

Sources/ContainerClient/Core/Filesystem.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public struct Filesystem: Sendable, Codable {
8787
/// A block based filesystem.
8888
public static func block(
8989
format: String, source: String, destination: String, options: MountOptions, cache: CacheMode = .auto,
90-
sync: SyncMode = .full
90+
sync: SyncMode = .fsync
9191
) -> Filesystem {
9292
.init(
9393
type: .block(format: format, cache: cache, sync: sync),
@@ -100,7 +100,7 @@ public struct Filesystem: Sendable, Codable {
100100
/// A named volume filesystem.
101101
public static func volume(
102102
name: String, format: String, source: String, destination: String, options: MountOptions,
103-
cache: CacheMode = .auto, sync: SyncMode = .full
103+
cache: CacheMode = .auto, sync: SyncMode = .fsync
104104
) -> Filesystem {
105105
.init(
106106
type: .volume(name: name, format: format, cache: cache, sync: sync),

0 commit comments

Comments
 (0)