avoid error with PathTooLongException: the TaskItem contains a list of all source files of a package separated by '|' which can lead to very long items. Reimplement FinishBuild() to split the list first before normalizing paths.

Author: rainers

msbuild/dbuild/MultiToolTaskVisualD.cs

@@ -182,8 +182,8 @@ protected int PrepareTasksPerPackage(ITaskItem[] sources)
             int compilationPackageCount = 0;
             foreach(var source in sources)
             {
-                string package = GetPackageName(source);
-
+                string package = GetPackageName(source);
+
                 List<List<ITaskItem>> taskItemsPerPackage;
                 if (!tasksPerPackage.TryGetValue(package, out taskItemsPerPackage))
                 {
@@ -219,7 +219,7 @@ protected int PrepareTasksPerPackage(ITaskItem[] sources)
                     taskItemsPerPackage.Add(itemList);
                     ++compilationPackageCount;
                 }
-            }
+            }
             return compilationPackageCount;
         }
 
@@ -604,7 +604,7 @@ protected int ProcessTasks()
                 }
                 if (!cts.IsCancellationRequested)
                 {
-                    FinishBuild(0);
+                    _FinishBuild(0);
                 }
             }
             else
@@ -689,8 +689,40 @@ select v.Trim())
                 }
             }
             return propertiesSet;
-        }
-
+        }
+
+        public override void Cancel()
+        {
+            cts.Cancel();
+            _FinishBuild(0);
+        }
+
+        static string _FormatRootingMarker(string sources)
+        {
+            string[] splitSources = sources.Split('|');
+            List<string> stringList = new List<string>(splitSources.Length);
+            foreach (string source in splitSources)
+                stringList.Add(Path.GetFullPath(source).ToUpperInvariant());
+            stringList.Sort((IComparer<string>)StringComparer.OrdinalIgnoreCase);
+            return string.Join("|", (IEnumerable<string>)stringList);
+        }
+
+        // to replace super.FinishBuild
+        protected int _FinishBuild(int exitCode)
+        {
+            if (PostBuildTrackingCleanup)
+                exitCode = PostExecuteTool(exitCode);
+            if (sourcesToCommandLines != null)
+            {
+                foreach (var allTask in taskScheduler.GetAllTasks())
+                    // original causes PathTooLongException for long list of files used as ITaskItem.itemSpec
+                    //sourcesToCommandLines.Remove(FileTracker.FormatRootingMarker((ITaskItem)new TaskItem(allTask.Key)));
+                    sourcesToCommandLines.Remove(_FormatRootingMarker(allTask.Key));
+                WriteSourcesToCommandLinesTable(sourcesToCommandLines);
+            }
+            return exitCode;
+        }
+
         protected override int PostExecuteTool(int exitCode)
         {
             // need to call PostExecuteTool per package
@@ -702,9 +734,9 @@ protected override int PostExecuteTool(int exitCode)
             foreach (var package in tasksPerPackage)
             {
                 foreach (var taskItems in package.Value)
-                {
-                    SourcesCompiled = Enumerable.Intersect(srcsCompiled, taskItems).ToArray();
-                    trackedInputFiles = taskItems.ToArray();
+                {
+                    SourcesCompiled = Enumerable.Intersect(srcsCompiled, taskItems).ToArray();
+                    trackedInputFiles = taskItems.ToArray();
                     exitCode = base.PostExecuteTool(exitCode);
                 }
             }