build D_Parser against .net-framework 4.5

add (experimental) option to evaluate value of constant expression in tooltip
new VC project: use $(LatestTargetPlatformVersion) as default sdk
remove a couple of options and rearrange setting pages

Author: rainers

CHANGES

@@ -988,21 +988,46 @@ Version history
 
 unreleased Version 0.48.0
 
-  * fixed uninstallation for VS2017
-  * installation for VS2013+ now uses PackageManifest format instead of Vsix
-  * restore project templates for VS2008, new project wizard doesn't work there'
-  * new mixed D/C++ VC project: optionally adding main in C++, setup precompiled headers
-  * avoid error message regarding altered assemblies with same version
-  * fix default library path if UCRT has different version than SDK
-  * fix help via F1 for dmd 2.072+
-  * show detected compiler version below installation path
-  * fix installation of the D icon for the solution explorer
+  * installation
+    - fixed uninstallation for VS2017
+    - installation for VS2013+ now uses PackageManifest format instead of Vsix
+    - VS2017: loading the Visual D package could crash with some VS installation "ids""
+    - avoid initial error message regarding altered assemblies with same version
+    - fix installation of the D icon for the solution explorer in VS2017
+    - installer hides options for VS2005-VS2012 if not installed
+  * new project wizard
+    - restore project templates for VS2008, new project wizard doesn't work there'
+    - mixed D/C++ VC project: optionally adding main in C++, setup precompiled headers
+    - new VCProject: now uses $(LatestTargetPlatformVersion) as WindowsTargetPlatformVersion to
+      avoid defaulting to Windows SDK 8.1
+  * settings
+    - fix default library path if UCRT has different version than SDK
+    - VS2017: D compiler installation paths and "demangle link errors" are now saved 
+	  to "HKCR\Softwre\Visual D" to be picked up by msbuild
+    - show detected compiler version below installation path
+	- removed option "parse source for syntax errors", now always on
+	- removed option "expansions from text buffer", now always off
+	- removed option "use semantic analysis for goto definition", now always on
+	- removed option "override linker settings from sc.ini", always on as linker no 
+	  longer set in sc.ini since dmd 2.079
+	- removed option "additional linker options", it was invisible anyway
+	- rearrange settings to better show their scope
+  * dparser
+    - semantic analysis did not work if "parse source for syntax errors" was disabled
+    - no semantic info for a package if any file in the package has fatal parser error
+    - now has semantic support for static foreach (thanks to Alexander Bothe)
+    - fixed "Find references"
+  * mago
+    - added option to show base class fields as direct fields
+    - allow suffix 'h' for hex numbers for better interoperablility with VS disassembly
+    - concord: can now show return values of functions stepped over (not slices or delegates 
+      on x64 or small non-POD-structs)
+    - concord: fix crash when showing children in data tooltip (mostly occured in VS2017)
+    - concord: allow dragging addresses to the disassembly window
+    - engine: Fix the way the debugger steps over instructions with REP prefix.
+  * cv2pdb
+    - can now detect VS2017 via Setup-COM-API
+	- some DWARF fixes
   * when pasting code to D source file newlines are adapted to surrounding code
-  * VS2017: D compiler installation paths are now saved to "HKCR\Softwre\Visual D" to be picked up by msbuild
-  * mago: added option to show base class fields as direct fields
-  * semantic analysis did not work if "parse source for syntax errors" was disabled
-  * mago: can now show return values of functions stepped over (not slices or delegates or small non-POD-structs)
-  * mago: fix crash when showing children in data tooltip
   * fixed "Compile and Run" on selection
-  * dparser: no semantic info for a package if any file in the package has fatal parser error
-  * dparser: now has semantic support for static foreach
+  * fix help via F1 for dmd 2.072+

Makefile

@@ -49,7 +49,7 @@ vdserver:
 	devenv /Project "vdserver"  /Build "$(CONFIG)|Win32" visuald_vs10.sln
 
 dparser:
-	cd vdc\abothe && $(MSBUILD15) vdserver.sln /p:Configuration=Release;Platform="Any CPU" /p:TargetFrameworkVersion=4.0 /p:DefineConstants=NET40 /t:Rebuild
+	cd vdc\abothe && $(MSBUILD15) vdserver.sln /p:Configuration=Release;Platform="Any CPU" /p:TargetFrameworkVersion=4.5 /p:DefineConstants=NET40 /t:Rebuild
 
 fake_dparser:
 	if not exist bin\Release\DParserCOMServer\nul md bin\Release\DParserCOMServer

doc/Editor.dd

@@ -20,8 +20,8 @@ $(UL
  )
 )
 
-$(P The colorizer can be configured in the "Colorizer" setup page of the language settings in
-Tools->Options->Text Editor->D->Colorizer: )
+$(P The colorizer can be configured in the "Editor" setup page of the language settings in
+Tools->Options->Text Editor->D->Editor: )
 
  $(IMG_CENTER images/editor-options.png)
 

msbuild/dbuild/CompileD.cs

@@ -889,11 +889,11 @@ protected static ushort GetPEArchitecture(string pFilePath)
                 {
                     using (System.IO.BinaryReader bReader = new System.IO.BinaryReader(fStream))
                     {
-                        if (bReader.ReadUInt16() == 23117) //check the MZ signature
+                        if (bReader.ReadUInt16() == 0x5A4D) //check the MZ signature
                         {
                             fStream.Seek(0x3A, System.IO.SeekOrigin.Current); //seek to e_lfanew.
                             fStream.Seek(bReader.ReadUInt32(), System.IO.SeekOrigin.Begin); //seek to the start of the NT header.
-                            if (bReader.ReadUInt32() == 17744) //check the PE\0\0 signature.
+                            if (bReader.ReadUInt32() == 0x4550) //check the PE\0\0 signature.
                             {
                                 fStream.Seek(20, System.IO.SeekOrigin.Current); //seek past the file header,
                                 architecture = bReader.ReadUInt16(); //read the magic number of the optional header.

msbuild/dcompile_defaults.props

@@ -27,8 +27,11 @@
 
     <DDemangleLink Condition="$(DDemangleLink) == ''">$([MSBuild]::GetRegistryValueFromView('HKEY_CURRENT_USER\SOFTWARE\Microsoft\VisualStudio\$(VisualStudioVersion)\ToolsOptionsPages\Projects\Visual D Settings', 'demangleError', '', RegistryView.Registry64, RegistryView.Registry32))</DDemangleLink>
     <DDemangleLink Condition="$(DDemangleLink) == ''">$([MSBuild]::GetRegistryValueFromView('HKEY_CURRENT_USER\SOFTWARE\Microsoft\VisualStudio\$(VisualStudioVersion)_Config\ToolsOptionsPages\Projects\Visual D Settings', 'demangleError', '', RegistryView.Registry64, RegistryView.Registry32))</DDemangleLink>
+    <DDemangleLink Condition="$(DDemangleLink) == ''">$([MSBuild]::GetRegistryValueFromView('HKEY_CURRENT_USER\SOFTWARE\Microsoft\VisualStudio\$(VisualStudioVersion)_Config\ToolsOptionsPages\Projects\Visual D Settings', 'demangleError', '', RegistryView.Registry64, RegistryView.Registry32))</DDemangleLink>
+    <DDemangleLink Condition="$(DDemangleLink) == ''">$([MSBuild]::GetRegistryValueFromView('HKEY_CURRENT_USER\SOFTWARE\Visual D\dbuild\$(VisualStudioVersion)', 'demangleError', '', RegistryView.Registry64, RegistryView.Registry32))</DDemangleLink>
     <DDemangleLink Condition="$(DDemangleLink) == ''">1</DDemangleLink>
-  </PropertyGroup>
+  
+</PropertyGroup>
 
   <ItemDefinitionGroup>
     <DCompile>

vdc/abothe/comserver/VDServer.cs

@@ -42,7 +42,7 @@ public interface IVDServer
 		void ConfigureSemanticProject(string filename, string imp, string stringImp, string versionids, string debugids, uint flags);
 		void ClearSemanticProject();
 		void UpdateModule(string filename, string srcText, bool verbose);
-		void GetTip(string filename, int startLine, int startIndex, int endLine, int endIndex);
+		void GetTip(string filename, int startLine, int startIndex, int endLine, int endIndex, int flags);
 		void GetTipResult(out int startLine, out int startIndex, out int endLine, out int endIndex, out string answer);
 		void GetSemanticExpansions(string filename, string tok, uint line, uint idx, string expr);
 		void GetSemanticExpansionsResult(out string stringList);
@@ -375,7 +375,7 @@ void runAsync(Action a)
             }
         }
 
-        public void GetTip(string filename, int startLine, int startIndex, int endLine, int endIndex)
+        public void GetTip(string filename, int startLine, int startIndex, int endLine, int endIndex, int flags)
 		{
             filename = normalizePath(filename);
             var ast = GetModule(filename);
@@ -428,26 +428,28 @@ public void GetTip(string filename, int startLine, int startIndex, int endLine,
                     while (tipText.Length > 0 && tipText[tipText.Length - 1] == '\a')
                         tipText.Length--;
 
-#if false
-                    var ctxt = _editorData.GetLooseResolutionContext(LooseResolution.NodeResolutionAttempt.Normal);
-                    ctxt.Push(_editorData);
-                    try
-                    {
-                        ISymbolValue v = null;
-                        var var = dn as DVariable;
-                        if (var != null && var.Initializer != null && var.IsConst)
-                            v = Evaluation.EvaluateValue(var.Initializer, ctxt);
-                        if (v == null && sr is IExpression)
-                            v = Evaluation.EvaluateValue(sr as IExpression, ctxt);
-                        if (v != null)
-                            tipText.Append("\avalue = ").Append(v.ToString());
-                    }
-                    catch(Exception e)
+                    bool eval = (flags & 1) != 0;
+                    if (eval)
                     {
-                        tipText.Append("\aException during evaluation = ").Append(e.Message);
+                        var ctxt = _editorData.GetLooseResolutionContext(LooseResolution.NodeResolutionAttempt.Normal);
+                        ctxt.Push(_editorData);
+                        try
+                        {
+                            ISymbolValue v = null;
+                            var var = dn as DVariable;
+                            if (var != null && var.Initializer != null && var.IsConst)
+                                v = Evaluation.EvaluateValue(var.Initializer, ctxt);
+                            if (v == null && sr is IExpression)
+                                v = Evaluation.EvaluateValue(sr as IExpression, ctxt);
+                            if (v != null)
+                                tipText.Append("\avalue = ").Append(v.ToString());
+                        }
+                        catch (Exception e)
+                        {
+                            tipText.Append("\aException during evaluation = ").Append(e.Message);
+                        }
+                        ctxt.Pop();
                     }
-                    ctxt.Pop();
-#endif
 
                     if (dn != null)
                         VDServerCompletionDataGenerator.GenerateNodeTooltipBody(dn, tipText);

vdc/ivdserver.d

@@ -32,7 +32,7 @@ import sdk.win32.oleauto;
 // expensive calls to be asynchronous: methods GetTip, GetDefinition, GetSemanticExpansions
 // and UpdateModule return immediately, but start some background processing.
 // The client (aka Visual D) polls the result with GetTipResult, GetDefinitionResult,
-// GetSemanticExpansionsResult // and GetParseErrors, repectively, until they return successfully.
+// GetSemanticExpansionsResult and GetParseErrors, repectively, until they return successfully.
 // While doing so, GetLastMessage is called to get status line messages (e.g. "parsing module...")
 //
 // All methods reference modules by their file name.
@@ -86,10 +86,11 @@ public:
 	// filename:   file name
 	// startLine, startIndex, endLine, endIndex: selected range in the editor
 	//                                           if start==end, mouse hovers without selection
+	// flags:      1 - try to evaluate constants/expressions
 	//
 	// it is assumed that the semantic analysis is forwarded to some other thread
 	// and that the status can be polled by GetTipResult
-	HRESULT GetTip(in BSTR filename, int startLine, int startIndex, int endLine, int endIndex);
+	HRESULT GetTip(in BSTR filename, int startLine, int startIndex, int endLine, int endIndex, int flags);
 
 	// get the result of the previous GetTip
 	//

vdc/vdserver.d

@@ -276,7 +276,7 @@ class VDServer : ComObject, IVDServer
 		return S_OK;
 	}
 
-	override HRESULT GetTip(in BSTR filename, int startLine, int startIndex, int endLine, int endIndex)
+	override HRESULT GetTip(in BSTR filename, int startLine, int startIndex, int endLine, int endIndex, int flags)
 	{
 		string fname = to_string(filename);
 		ast.Module mod;

vdc/vdserver.idl

@@ -22,7 +22,7 @@ interface IVDServer : IUnknown
 	HRESULT ConfigureSemanticProject([in] BSTR filename, [in] BSTR imp, [in] BSTR stringImp, [in] BSTR versionids, [in] BSTR debugids, [in] DWORD flags);
 	HRESULT ClearSemanticProject();
 	HRESULT UpdateModule([in] BSTR filename, [in] BSTR srcText, [in] BOOL verbose);
-	HRESULT GetTip([in] BSTR filename, [in] DWORD startLine, [in] DWORD startIndex, [in] DWORD endLine, [in] DWORD endIndex);
+	HRESULT GetTip([in] BSTR filename, [in] DWORD startLine, [in] DWORD startIndex, [in] DWORD endLine, [in] DWORD endIndex, [in] DWORD flags);
 	HRESULT GetTipResult([out] DWORD *startLine, [out] DWORD *startIndex, [out] DWORD *endLine, [out] DWORD *endIndex, [out,retval] BSTR* answer);
 	HRESULT GetSemanticExpansions([in] BSTR filename, [in] BSTR tok, [in] DWORD line, [in] DWORD idx, [in] BSTR expr);
 	HRESULT GetSemanticExpansionsResult([out,retval] BSTR* stringList);

vdextensions/vdextensions.sln

@@ -1,7 +1,7 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
-# Visual Studio 14
-VisualStudioVersion = 14.0.25420.1
+# Visual Studio 15
+VisualStudioVersion = 15.0.28010.2016
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{FAE04EC0-301F-11D3-BF4B-00C04F79EFBC}") = "vdextensions", "vdextensions.csproj", "{3A338E86-A08A-4F9A-8DB1-A5C280773BA3}"
 EndProject
@@ -185,4 +185,7 @@ Global
 	GlobalSection(SolutionProperties) = preSolution
 		HideSolutionNode = FALSE
 	EndGlobalSection
+	GlobalSection(ExtensibilityGlobals) = postSolution
+		SolutionGuid = {D174EDB9-40A2-454C-8997-4BDB7FB1C00C}
+	EndGlobalSection
 EndGlobal