Image is locked up after converting to PDF

[tomasr78]

When I try to convert Image to PDF sometimes the file is not released after conversion and I get an error that the file is used.

The code below demonstrates the issue and the second block of the code File.Open I am using to test if the file is in use.
I get error:

System.IO.IOExceptionMessageThe process cannot access the file 'C:\Temp\bXR1MJo1\image.pdf' because it is being used by another process.StackTraceString   at System.IO.__Error.WinIOError(Int32 errorCode, String maybeFullPath)
   at System.IO.FileStream.Init(String path, FileMode mode, FileAccess access, Int32 rights, Boolean useRights, FileShare share, Int32 bufferSize, FileOptions options, SECURITY_ATTRIBUTES secAttrs, String msgPath, Boolean bFromProxy, Boolean useLongPath, Boolean checkHost)
   at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share)

Test code

            var magickReadSettings = new MagickReadSettings();
            const MagickFormat magickFormat = MagickFormat.Pdf;
            var destinationFileName = $@"{DestinationLocation}\image.{magickFormat.ToString().ToLower()}";

            using (var image = new MagickImage(Conversion.SourceFile.ToString(), magickReadSettings))
            {
                image.Settings.SetDefines(new PdfWriteDefines
                {
                    Author = "Image",
                    Producer = "Magick.net"
                });
                
                var colorSpace = ConverterParameter.ColorSpace();
                if (!Conversion.IsParameterSet(colorSpace))
                    image.ColorSpace = Conversion.ToString(colorSpace).ToEnum<ColorSpace>();
                image.Write(destinationFileName, magickFormat);
            }

        
         try
            {
                using(var stream = File.Open(destinationFileName, FileMode.Open, FileAccess.Read, FileShare.Read))
                {
                    stream.Close();
                }
            }
            catch (Exception e)
            {
                Logger.Main.LogError($"The file is locked FileMode.Open, FileAccess.Read, FileShare.Read {destinationFileName}",e);
            }

[dlemstra]

Is this reproducable with a specific input file?

[tomasr78]

When are you planning to release the next version? I will test it and let you know.

[dlemstra]

The new release has been published earlier this week.

[tomasr78]

Could you drop the link to that commit? I would like to review the fix.

[dlemstra]

This is the commit: ImageMagick/ImageMagick@225b51d. And thanks for helping out with this.

[dlemstra]

Are you still experiencing this issue?

[tomasr78]

Sorry for the delay, I have tried to narrow down the problems and that's what I found.
It seems the problem is not related directly to Magick.net but to Process.Start. I suppose you also use Process.Start to launch ImageMagick.

So the problem is that Magick.Net and my console app use Process.Start at the same time to start other console apps and somehow they interact and lock each other files.

This problem only happens when Process.StartInfo.UseShellExecute is set to False. I already spend five days trying to find out what is causing the problem and can't find it yet.

    using (var p = new Process
    {
        StartInfo =
        {
            FileName = "c:\commandLine.exe",
            Arguments = "c:\file.jpg",
            UseShellExecute = false,
            RedirectStandardError = true,
            RedirectStandardOutput = true
        }
    })
    {
        try
        {
            p.Start();
            p.PriorityClass = ProcessPriorityClass.Normal;

            p.WaitForExit();

            var output = await p.StandardOutput.ReadToEndAsync();
            var error = await p.StandardError.ReadToEndAsync();
            var exitCode = p.ExitCode;
            return .....; 

        }
        finally
        {
            try
            {
                if (!p.HasExited)
                    p.Kill();
            }
            catch (InvalidOperationException)
            {
                //The process is not found, probably executable was not fount                    
            }

            p.Close();
        }
    } 

[tomasr78]

Dirk, could you show me the code where you run ImageMagick? I think there is a bug because if we remove Magick.Net our Processes start working fine and files are not locked anymore.