Probable mistake percentage of percentage?

[Gounlaf]

👋

Looking at:

Magick.NET/src/Magick.NET/MagickImage.cs

Lines 1474 to 1483 in 167add4

	/// <summary>
	/// Uses a multi-stage algorithm to detect a wide range of edges in images.
	/// </summary>
	/// <param name="radius">The radius of the gaussian smoothing filter.</param>
	/// <param name="sigma">The sigma of the gaussian smoothing filter.</param>
	/// <param name="lower">Percentage of edge pixels in the lower threshold.</param>
	/// <param name="upper">Percentage of edge pixels in the upper threshold.</param>
	/// <exception cref="MagickException">Thrown when an error is raised by ImageMagick.</exception>
	public void CannyEdge(double radius, double sigma, Percentage lower, Percentage upper)
	=> _nativeInstance.CannyEdge(radius, sigma, lower.ToDouble() / 100, upper.ToDouble() / 100);

Seeing that lower & upper are divided again by 100 make me thing it's a mistake, but not sure about it.

Regards.

Edit: I see the same one for DrawableFillOpacity.Draw, and that's all (except for the PercentageHelper but what I understand is legit for this class).
And looking at ImageMagick corresponding functions add more confusion... I see some method that divide the percentage / 100 again, and some doesn't.

[dlemstra]

There is some difference between the methods in ImageMagick. This method requires a value from 0.0 to 1.0.

[Gounlaf]

OK. Thanks for the clarification 🙂.