passing tests

Author: zilto

dlt/common/validation.py

@@ -108,7 +108,7 @@ def verify_prop(pk: str, pv: Any, t: Any) -> None:
                         failed_validations, key=lambda ex: ex.path.count("/"), reverse=True
                     )
                     for failed in failed_validations:
-                        msg += f"For {get_type_name(failed.expected_type)}: " + str(failed) + "\n"
+                        msg += f"For `{get_type_name(failed.expected_type)}`: " + str(failed) + "\n"
                     raise DictValidationException(
                         msg,
                         path,
@@ -204,8 +204,8 @@ def verify_prop(pk: str, pv: Any, t: Any) -> None:
                 if inspect.isclass(t):
                     if not isinstance(pv, t):
                         raise DictValidationException(
-                            f"field '{pk}' expects class '{type_name}' but got instance of"
-                            f" '{pv_type_name}'",
+                            f"field `{pk}` expects class `{type_name}` but got instance of"
+                            f" `{pv_type_name}`",
                             path,
                             t,
                             pk,
@@ -214,7 +214,7 @@ def verify_prop(pk: str, pv: Any, t: Any) -> None:
                 # dropped, just __name__ can be used
                 type_name = get_type_name(t)
                 raise DictValidationException(
-                    f"field '{pk}' has expected type '{type_name}' which lacks validator",
+                    f"field `{pk}` has expected type `{type_name}` which lacks validator",
                     path,
                     t,
                     pk,

dlt/destinations/impl/bigquery/bigquery.py

@@ -225,7 +225,7 @@ def create_load_job(
                 if table["write_disposition"] != "append":
                     raise DestinationTerminalException(
                         "BigQuery streaming insert can only be used with"
-                        " `write_disposition='append'`.Resource received"
+                        " `write_disposition='append'`. Resource received"
                         f" `write_disposition={table['write_disposition']}`"
                     )
                 if file_path.endswith(".jsonl"):

tests/load/bigquery/test_bigquery_streaming_insert.py

@@ -50,9 +50,10 @@ def test_resource():
     # pick the failed job
     assert isinstance(pip_ex.value.__cause__, LoadClientJobFailed)
     assert (
-        """BigQuery streaming insert can only be used with `append`"""
-        """ write_disposition, while the given resource has `merge`."""
-    ) in pip_ex.value.__cause__.failed_message
+        "BigQuery streaming insert can only be used with `write_disposition='append'`"
+        "Resource received `write_disposition=merge`"
+        in pip_ex.value.__cause__.failed_message
+    )
 
 
 def test_bigquery_streaming_nested_data():

tests/load/bigquery/test_bigquery_table_builder.py

@@ -568,9 +568,7 @@ def some_data() -> Iterator[Dict[str, Any]]:
 
     with pytest.raises(
         ValueError,
-        match=(
-            "^`partition` must be a single column name as a string or a PartitionTransformation.$"
-        ),
+        match="`partition` must be a single column name as a `str` or a `PartitionTransformation`.",
     ):
         bigquery_adapter(some_data, partition=["col1", "col2"])
 

tests/load/databricks/test_databricks_configuration.py

@@ -110,7 +110,7 @@ def test_databricks_auth_invalid() -> None:
 
 def test_databricks_missing_config_catalog() -> None:
     with pytest.raises(
-        ConfigurationValueError, match="Configuration error: Missing required parameter 'catalog'*"
+        ConfigurationValueError, match="Configuration error: Missing required parameter `catalog`"
     ):
         os.environ["DESTINATION__DATABRICKS__CREDENTIALS__CATALOG"] = ""
         bricks = databricks()
@@ -120,7 +120,7 @@ def test_databricks_missing_config_catalog() -> None:
 def test_databricks_missing_config_http_path() -> None:
     with pytest.raises(
         ConfigurationValueError,
-        match="Configuration error: Missing required parameter 'http_path'*",
+        match="Configuration error: Missing required parameter `http_path`",
     ):
         os.environ["DESTINATION__DATABRICKS__CREDENTIALS__HTTP_PATH"] = ""
         bricks = databricks()
@@ -130,7 +130,7 @@ def test_databricks_missing_config_http_path() -> None:
 def test_databricks_missing_config_server_hostname() -> None:
     with pytest.raises(
         ConfigurationValueError,
-        match="Configuration error: Missing required parameter 'server_hostname'*",
+        match="Configuration error: Missing required parameter `server_hostname`",
     ):
         os.environ["DESTINATION__DATABRICKS__CREDENTIALS__SERVER_HOSTNAME"] = ""
         bricks = databricks()

tests/sources/rest_api/configurations/source_configs.py

@@ -84,7 +84,7 @@
         },
     ),
     ConfigTest(
-        expected_message="field `paginator='invalid_paginator'` is not one of:",
+        expected_message="field `paginator` expects the following types: ",
         exception=DictValidationException,
         config={
             "client": {

tests/sources/rest_api/configurations/test_auth_config.py

@@ -314,5 +314,5 @@ def test_validation_masks_auth_secrets() -> None:
         rest_api_source(incorrect_config)
     assert (
         re.search("sensitive-secret", str(e.value)) is None
-    ), "unexpectedly printed 'sensitive-secret'"
-    assert e.match(re.escape("'{'type': 'bearer', 'location': 'header', 'token': 's*****t'}'"))
+    ), "unexpectedly printed `sensitive-secret`"
+    assert e.match(re.escape("`{'type': 'bearer', 'location': 'header', 'token': 's*****t'}`"))

tests/sources/rest_api/configurations/test_incremental_config.py

@@ -53,7 +53,7 @@ def test_invalid_incremental_type_is_not_accepted() -> None:
     with pytest.raises(ValueErrorWithKnownValues) as e:
         _validate_param_type(request_params)
 
-    assert e.match("Received invalid value `since['type']=no_incremental`.")
+    assert e.match(r"Received invalid value `since\['type'\]=no_incremental`.")
 
 
 def test_one_resource_cannot_have_many_incrementals() -> None:
@@ -185,15 +185,16 @@ def test_does_not_construct_incremental_from_request_param_with_unsupported_incr
         setup_incremental_object(param_config_2)
 
     assert e.match(
-        "Only start_param and initial_value are allowed in the configuration of param: since_2."
+        "Only `start_param` and `initial_value` are allowed in the configuration of param:"
+        " `since_2`."
     )
 
     param_config_3 = {"since_3": incremental_with_init_and_end}
 
     with pytest.raises(ValueError) as e:
         setup_incremental_object(param_config_3)
 
-    assert e.match("Only initial_value is allowed in the configuration of param: since_3.")
+    assert e.match("Only `initial_value` is allowed in the configuration of param: `since_3`.")
 
 
 def test_constructs_incremental_from_endpoint_config_incremental(

tests/sources/rest_api/configurations/test_paginator_config.py

@@ -148,7 +148,6 @@ def test_allow_deprecated_json_response_paginator_2(mock_api_server) -> None:
 def test_error_message_invalid_paginator() -> None:
     with pytest.raises(ValueError) as e:
         create_paginator("non_existing_method")  # type: ignore
-    assert (
-        str(e.value)
-        == "Received invalid value `paginator_name=non_existing_method`. Valid values are:"
+    assert e.match(
+        r"Received invalid value `paginator_name=non_existing_method`\. Valid values are:"
     )

tests/sources/rest_api/configurations/test_response_actions_config.py

@@ -45,11 +45,15 @@ class C:
 
     with pytest.raises(TypeErrorWithKnownTypes) as e_1:
         _handle_response_action(response, {"status_code": 200, "action": C()})  # type: ignore[typeddict-item]
-    assert e_1.match("Received invalid value `action['action']=*` of type `C`. Valid types are:")
+    assert e_1.match(
+        r"Received invalid value `action\['action'\]=.*` of type `C`\. Valid types are:"
+    )
 
     with pytest.raises(TypeErrorWithKnownTypes) as e_2:
         _handle_response_action(response, {"status_code": 200, "action": 123})  # type: ignore[typeddict-item]
-    assert e_2.match("Received invalid value `action['action']=*` of type `C`. Valid types are:")
+    assert e_2.match(
+        r"Received invalid value `action\['action'\]=.*` of type `int`\. Valid types are:"
+    )
 
     assert ("ignore", None) == _handle_response_action(
         response, {"status_code": 200, "action": "ignore"}