test: add opt-in image-based domain shutdown acc test

Author: dmacvicar

Makefile

@@ -1,10 +1,14 @@
-.PHONY: help build install test testacc testacc-tofu sweep lint fmt clean generate
+.PHONY: help build install test testacc testacc-tofu sweep lint fmt clean generate testdeps-acc
 
 # Default target
 .DEFAULT_GOAL := help
 
 # Version can be overridden
 VERSION ?= dev
+CIRROS_VERSION ?= 0.6.2
+TEST_IMAGE_DIR ?= .cache/test-images
+CIRROS_IMAGE ?= $(TEST_IMAGE_DIR)/cirros-$(CIRROS_VERSION)-x86_64-disk.img
+CIRROS_URL ?= https://download.cirros-cloud.net/$(CIRROS_VERSION)/cirros-$(CIRROS_VERSION)-x86_64-disk.img
 
 # Build flags
 LDFLAGS := -ldflags "-X main.version=$(VERSION)"
@@ -35,6 +39,17 @@ testacc: generate ## Run acceptance tests (requires running libvirt)
 	@echo "Running acceptance tests..."
 	@TF_ACC=1 go test -count=1 -v -timeout 10m ./internal/provider
 
+testdeps-acc: ## Download/cache acceptance test image dependencies (CirrOS)
+	@echo "Preparing acceptance test image dependencies..."
+	@mkdir -p $(TEST_IMAGE_DIR)
+	@if [ ! -f "$(CIRROS_IMAGE)" ]; then \
+		echo "Downloading $(CIRROS_URL) -> $(CIRROS_IMAGE)"; \
+		curl -fL --retry 3 --retry-delay 2 -o "$(CIRROS_IMAGE)" "$(CIRROS_URL)"; \
+	else \
+		echo "Using cached image: $(CIRROS_IMAGE)"; \
+	fi
+	@echo "Set LIBVIRT_TEST_ACPI_IMAGE=$(CIRROS_IMAGE) to run image-based shutdown ACC test."
+
 testacc-tofu: ## Run acceptance tests with OpenTofu
 	@TF_ACC_TERRAFORM_PATH=$$(which tofu) TF_ACC_PROVIDER_NAMESPACE=dmacvicar TF_ACC_PROVIDER_HOST=registry.terraform.io $(MAKE) testacc
 

internal/provider/domain_resource_test.go

@@ -3,8 +3,10 @@ package provider
 import (
 	"context"
 	"fmt"
+	"os"
 	"strings"
 	"testing"
+	"time"
 
 	golibvirt "github.com/digitalocean/go-libvirt"
 	libvirtclient "github.com/dmacvicar/terraform-provider-libvirt/v2/internal/libvirt"
@@ -456,6 +458,58 @@ func TestAccDomainResource_destroyShutdownStoppedDomainDefaultTimeout(t *testing
 	})
 }
 
+func TestAccDomainResource_destroyShutdownRunningWithImage(t *testing.T) {
+	imagePath := os.Getenv("LIBVIRT_TEST_ACPI_IMAGE")
+	if imagePath == "" {
+		t.Skip("set LIBVIRT_TEST_ACPI_IMAGE to run shutdown test with a real guest image")
+	}
+	if _, err := os.Stat(imagePath); err != nil {
+		t.Skipf("LIBVIRT_TEST_ACPI_IMAGE does not exist: %v", err)
+	}
+	testAccRequireDefaultPool(t)
+
+	resource.Test(t, resource.TestCase{
+		PreCheck:                 func() { testAccPreCheck(t) },
+		ProtoV6ProviderFactories: testAccProtoV6ProviderFactories,
+		CheckDestroy:             testAccCheckDomainDestroy,
+		Steps: []resource.TestStep{
+			{
+				Config: testAccDomainResourceConfigDestroyShutdownRunningWithImage("test-domain-shutdown-image", "test-volume-shutdown-image", imagePath, 120),
+				Check: resource.ComposeAggregateTestCheckFunc(
+					resource.TestCheckResourceAttr("libvirt_domain.test", "name", "test-domain-shutdown-image"),
+					resource.TestCheckResourceAttr("libvirt_domain.test", "running", "true"),
+					testAccCheckDomainIsRunning("test-domain-shutdown-image"),
+				),
+			},
+			{
+				// Give the guest time to finish early boot before testing shutdown behavior.
+				PreConfig: func() { time.Sleep(45 * time.Second) },
+				Config:    testAccDomainResourceConfigDestroyShutdownRunningWithImage("test-domain-shutdown-image", "test-volume-shutdown-image", imagePath, 120),
+				Destroy:   true,
+			},
+		},
+	})
+}
+
+func testAccRequireDefaultPool(t *testing.T) {
+	t.Helper()
+
+	ctx := context.Background()
+	client, err := libvirtclient.NewClient(ctx, testAccLibvirtURI())
+	if err != nil {
+		t.Skipf("failed to create libvirt client: %v", err)
+	}
+	defer func() { _ = client.Close() }()
+
+	pool, err := client.Libvirt().StoragePoolLookupByName("default")
+	if err != nil {
+		t.Skipf("default storage pool not available: %v", err)
+	}
+
+	// Ignore error if pool is already active; we only need a usable pool.
+	_ = client.Libvirt().StoragePoolCreate(pool, 0)
+}
+
 func TestAccDomainResource_updateWithRunning(t *testing.T) {
 	resource.Test(t, resource.TestCase{
 		PreCheck:                 func() { testAccPreCheck(t) },
@@ -698,6 +752,79 @@ resource "libvirt_domain" "test" {
 `, name)
 }
 
+func testAccDomainResourceConfigDestroyShutdownRunningWithImage(domainName, volumeName, imagePath string, timeout int64) string {
+	return fmt.Sprintf(`
+resource "libvirt_volume" "test" {
+  name = "%[2]s.qcow2"
+  pool = "default"
+  target = {
+    format = {
+      type = "qcow2"
+    }
+  }
+  create = {
+    content = {
+      url = %[3]q
+    }
+  }
+}
+
+resource "libvirt_domain" "test" {
+  name    = %[1]q
+  memory  = 512
+  memory_unit = "MiB"
+  vcpu    = 1
+  type    = "kvm"
+  running = true
+
+  destroy = {
+    shutdown = {
+      timeout = %[4]d
+    }
+  }
+
+  os = {
+    type         = "hvm"
+    type_arch    = "x86_64"
+    type_machine = "q35"
+  }
+
+  features = {
+    acpi = true
+  }
+
+  devices = {
+    disks = [
+      {
+        source = {
+          volume = {
+            pool   = "default"
+            volume = libvirt_volume.test.name
+          }
+        }
+        driver = {
+          name = "qemu"
+          type = "qcow2"
+        }
+        target = {
+          dev = "sda"
+          bus = "sata"
+        }
+      }
+    ]
+    graphics = [
+      {
+        vnc = {
+          auto_port = true
+          listen    = "0.0.0.0"
+        }
+      }
+    ]
+  }
+}
+`, domainName, volumeName, imagePath, timeout)
+}
+
 func testAccCheckDomainIsRunning(name string) resource.TestCheckFunc {
 	return func(s *terraform.State) error {
 		ctx := context.Background()